Page MenuHomePhabricator
Create Task
Maniphest T202306

Remove EventLogging code from RelatedArticles
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The Schema:RelatedArticles has been disabled for some time and should be removed

Acceptance criteria

  • Remove module ext.relatedArticles.readMore.eventLogging
  • Remove the 2 calls to ext.relatedArticles.logReady and ext.relatedArticles.logEnabled
  • Remove wgRelatedArticlesEnabledBucketSize (php config, documentation and JS usage)

QA steps

Verify that related articles shows on the beta cluster (https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=Related_Articles_2&mobileaction=toggle_view_mobile)
On https://en.wikivoyage.beta.wmflabs.org/wiki/Tokushima it should show on desktop.

Sign off steps

Details

SubjectRepoBranchLines +/-
Remove dead config relating to wgRelatedArticlesEnabledBucketSizeoperations/mediawiki-configmaster+0 -8
Remove EventLogging/A-B test code from RelatedArticlesmediawiki/extensions/RelatedArticlesmaster+5 -200
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Aug 20 2018, 4:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2018, 4:44 PM
Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Aug 20 2018, 4:44 PM
Krinkle added a parent task: T187207: Spin out a tiny EventLogging RL module for lightweight logging.Aug 20 2018, 4:46 PM
Krinkle removed a parent task: T187207: Spin out a tiny EventLogging RL module for lightweight logging.
ovasileva triaged this task as Medium priority.Aug 21 2018, 7:47 AM
Jdlrobson updated the task description. (Show Details)Aug 21 2018, 4:39 PM
Jdlrobson updated the task description. (Show Details)Aug 21 2018, 4:43 PM
Jdlrobson set the point value for this task to 2.
ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Sep 10 2018, 5:20 PM
ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Web-Team-Backlog.Sep 10 2018, 5:22 PM
Jdlrobson claimed this task.Sep 13 2018, 6:16 PM
Jdlrobson moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
gerritbot subscribed.Sep 13 2018, 6:43 PM

Change 460410 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/RelatedArticles@master] Remove EventLogging/A-B test code from RelatedArticles

https://gerrit.wikimedia.org/r/460410

gerritbot added a project: Patch-For-Review.Sep 13 2018, 6:43 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 13 2018, 6:43 PM
Jdlrobson moved this task from Needs Code Review to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 17 2018, 11:30 PM
• Tbayer subscribed.Sep 18 2018, 12:09 AM
Jdlrobson moved this task from Doing to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 18 2018, 5:59 PM
Krinkle added a project: Performance-Team (Radar).Sep 18 2018, 10:32 PM
Krinkle awarded a token.
phuedx moved this task from Needs QA to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 20 2018, 5:16 PM
phuedx subscribed.

https://gerrit.wikimedia.org/r/460410 hasn't been merged and is V:-1.

phuedx unsubscribed.Sep 20 2018, 5:16 PM
Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 20 2018, 5:50 PM
gerritbot added a comment.Sep 24 2018, 6:46 PM

Change 460410 merged by jenkins-bot:
[mediawiki/extensions/RelatedArticles@master] Remove EventLogging/A-B test code from RelatedArticles

https://gerrit.wikimedia.org/r/460410

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 24 2018, 7:00 PM
Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 24 2018, 7:19 PM
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Sep 24 2018, 8:10 PM
Jdlrobson updated the task description. (Show Details)Sep 24 2018, 8:46 PM
gerritbot added a comment.Sep 24 2018, 8:47 PM

Change 462573 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Remove dead config relating to wgRelatedArticlesEnabledBucketSize

https://gerrit.wikimedia.org/r/462573

Jdlrobson removed Jdlrobson as the assignee of this task.Sep 24 2018, 8:49 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.

I've run through the QA steps myself, so I think this can skip QA. Signer off should be a developer and they will need to SWAT https://gerrit.wikimedia.org/r/462573

pmiazga claimed this task.Sep 25 2018, 5:04 PM

Most probably we cannot SWAT https://gerrit.wikimedia.org/r/462573 before Tuesday (train break), I'll check that with SWAT team, and sign-off/swat the task ASAP

Jdlrobson updated the task description. (Show Details)Sep 25 2018, 6:32 PM
Jdlrobson moved this task from Ready for Signoff to Blocked on Others on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 27 2018, 5:09 PM
pmiazga moved this task from Blocked on Others to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Oct 1 2018, 5:03 PM
pmiazga added a comment.Oct 2 2018, 5:11 PM

I'll SWAT the change tomorrow (Oct 3rd during European swat window)

ovasileva moved this task from Readers-Web-Kanbanana-Board-2018-19-Q1 to Readers-Web-Kanbanana-Board-2018-19-Q2 on the Web-Team-Backlog board.Oct 2 2018, 5:30 PM
ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1).
ovasileva moved this task from To Do to Blocked on Others on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 2 2018, 5:35 PM
ovasileva moved this task from Blocked on Others to To Do on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
ovasileva moved this task from To Do to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 2 2018, 5:37 PM
gerritbot added a comment.Oct 3 2018, 11:34 AM

Change 462573 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove dead config relating to wgRelatedArticlesEnabledBucketSize

https://gerrit.wikimedia.org/r/462573

Stashbot subscribed.Oct 3 2018, 11:42 AM

Mentioned in SAL (#wikimedia-operations) [2018-10-03T11:42:08Z] <pmiazga@deploy1001> Synchronized wmf-config: SWAT: [[gerrit:462573|Remove dead config relating to wgRelatedArticlesEnabledBucketSize (T202306)]] (duration: 00m 57s)

pmiazga updated the task description. (Show Details)Oct 3 2018, 11:46 AM
pmiazga updated the task description. (Show Details)Oct 3 2018, 11:55 AM

Deployed, looks ok, no dead code found.

pmiazga closed this task as Resolved.Oct 3 2018, 11:56 AM
Jdlrobson added a comment.Oct 3 2018, 5:52 PM

Remove RelatedArticles schema from our dashboard (https://grafana.wikimedia.org/dashboard/db/reading-web-dashboard?orgId=1)

For completion, this wasn't done. I just did this myself just now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL