Maniphest T202517

View content and edit content overlaid on top of each other (?) on mobile visual editor
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Deskana
	Aug 22 2018, 11:41 AM

Description

Steps to reproduce:

On your mobile device, go to https://en.m.wikipedia.org/wiki/Stockport
Open the mobile visual editor
Scroll whilst the page is loading

Expected:

Read content, or edit content, or a loading indicator should be shown

Actual:

Content is shown overlapping other content (I think it's edit and read content?)

Screenshot_20180822-123013.png (2×1 px, 613 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Guard against VE overlay being shown twice	mediawiki/extensions/MobileFrontend	master	+4 -2

Customize query in gerrit

Related Objects

Mentioned In: T202513: Edit interface loaded with double toolbar on mobile web
Mentioned Here: T202987: Mobile: Content styles aren't added until surface has been rendered, resulting in FOUC
T202513: Edit interface loaded with double toolbar on mobile web

Event Timeline

• Deskana created this task.Aug 22 2018, 11:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2018, 11:41 AM

• Deskana triaged this task as Medium priority.Aug 22 2018, 11:41 AM

• Deskana moved this task from To Triage to Up next on the VisualEditor board.

• Deskana updated the task description. (Show Details)Aug 22 2018, 4:13 PM

• Deskana moved this task from Up next to Current work on the VisualEditor board.Aug 22 2018, 5:25 PM

• Deskana edited projects, added VisualEditor (Current work); removed VisualEditor.

@Deskana: I'm not seeing this on Android, even with 4x CPU throttling...

It could be related to showing the editor too early, which I'm looking in to in T202513

In T202517#4524336, @Esanders wrote:

@Deskana: I'm not seeing this on Android, even with 4x CPU throttling...

It could be related to showing the editor too early, which I'm looking in to in T202513

Hmm. My Android device is a Nexus 6 and is not especially old. The page stayed this way for several seconds, and was otherwise responsive during that period. I don't know what to suggest.

Change 454807 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Add 'content' class to surface before it is shown

https://gerrit.wikimedia.org/r/454807

gerritbot added a project: Patch-For-Review.Aug 23 2018, 12:48 PM

Esanders claimed this task.Aug 23 2018, 12:49 PM

Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.

Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Aug 23 2018, 2:02 PM

I'll separate my fix into a new issue, not sure if they're the same yet: T202987

Esanders removed a project: Patch-For-Review.Aug 28 2018, 12:26 PM

Esanders moved this task from Code review to Incoming on the VisualEditor (Current work) board.

Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.Aug 28 2018, 12:46 PM

Esanders mentioned this in T202513: Edit interface loaded with double toolbar on mobile web.Aug 28 2018, 12:48 PM

Change 455826 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/MobileFrontend@master] Guard against VE overlay being shown twice

https://gerrit.wikimedia.org/r/455826

gerritbot added a project: Patch-For-Review.Aug 28 2018, 1:04 PM

Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Aug 28 2018, 1:05 PM

• Deskana added a project: Editing Q1 2018-19 mobile improvements.Aug 28 2018, 4:04 PM

Change 455826 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Guard against VE overlay being shown twice

https://gerrit.wikimedia.org/r/455826

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Aug 29 2018, 2:00 AM

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Aug 29 2018, 1:28 PM

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Mobile; removed Patch-For-Review.Sep 13 2018, 11:33 PM

Ryasmeen added a project: Verified.Sep 14 2018, 3:39 AM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

I can't reproduce this now, so I guess we have to assume that this is fixed until we prove otherwise.

	F25220031: Screenshot_20180822-123013.png
	Aug 22 2018, 11:41 AM

View content and edit content overlaid on top of each other (?) on mobile visual editorClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

View content and edit content overlaid on top of each other (?) on mobile visual editor
Closed, ResolvedPublic
Actions