Page MenuHomePhabricator

Grrrrit-wm crashes on wip-state-changed events
Closed, ResolvedPublic

Description

2018-08-25 17:05:40,942 - wikibugs.wb2-grrrrit - INFO - {"changer":{"name":"Zoranzoki21","email":"zorandori4444@gmail.com","username":"zoranzoki21"},"change":{"project":"operations/mediawiki-config","branch":"master","topic":"T201491","id":"I96ce68f074b1c1820df8cb25ce0b3a81a4e0f60e","number":455354,"subject":"Fix \"seperated\" typo in MWMultiVersion.php file","owner":{"name":"Zoranzoki21","email":"zorandori4444@gmail.com","username":"zoranzoki21"},"url":"https://gerrit.wikimedia.org/r/455354","commitMessage":"Fix \"seperated\" typo in MWMultiVersion.php file\n\nChange-Id: I96ce68f074b1c1820df8cb25ce0b3a81a4e0f60e\n","createdOn":1535216715,"status":"NEW"},"project":"operations/mediawiki-config","refName":"refs/heads/master","changeKey":{"id":"I96ce68f074b1c1820df8cb25ce0b3a81a4e0f60e"},"type":"wip-state-changed","eventCreatedOn":1535216740}

2018-08-25 17:05:40,943 - wikibugs.wb2-grrrrit - ERROR - Error, probably SSH connection dropped.
Traceback (most recent call last):
  File "/data/project/wikibugs/wikibugs2/grrrrit.py", line 246, in <module>
    main()
  File "/data/project/wikibugs/wikibugs2/grrrrit.py", line 226, in main
    processed = process_event(parsed)
  File "/data/project/wikibugs/wikibugs2/grrrrit.py", line 49, in process_event
    if not event['change']['wip']:
KeyError: 'wip'

Event Timeline

Change 455363 had a related patch set uploaded (by Merlijn van Deen; owner: Merlijn van Deen):
[labs/tools/wikibugs2@master] Remove support for WIP reporting

https://gerrit.wikimedia.org/r/455363

Change 455363 merged by jenkins-bot:
[labs/tools/wikibugs2@master] Remove support for WIP reporting

https://gerrit.wikimedia.org/r/455363

@Paladox: I'm not sure if this is a breakage due to a Gerrit upgrade or whether this is due to some other reason. I couldn't figure out a simple fix to the problem (I think likely these events sholuld not be reported, and some other events /should/?), and I think the WIP reporting is useful but not critical, so I have backed out the whole WIP reporting for now.