In 446775 we introduced a mw.hook allowing 3rd parties to extend the entity selector suggestions.
PropertySuggester could now use this hook to avoid monkey patching here:
https://github.com/Wikidata-lib/PropertySuggester/blob/master/modules/ext.PropertySuggester.EntitySelector.js
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Teach EntitySelector._combineResults() to evaluate rank | mediawiki/extensions/Wikibase | master | +126 -5 |
Change 458187 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[mediawiki/extensions/PropertySuggester@master] Change property suggester to use hook instead of monkey patching
Change 459505 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[mediawiki/extensions/Wikibase@master] Teach EntitySelector._combineResults() to evaluate rank
Change 459505 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Teach EntitySelector._combineResults() to evaluate rank
What's the state of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PropertySuggester/+/458187? @Jonas can it be merged?
I believe now that https://gerrit.wikimedia.org/r/459505 is merged we can go ahead.
Jonas' -2
We need to first teach the hook to evaluate ranking information, otherwise we have a running condition that randomly sorts suggestions.
is, I believe, satisfied by the above patch. Since @Jonas is now hiking and also away I'm going to go ahead and remove the -2.
I have tested it locally and am happy that in my dev setup that the suggestions are sorted by rank