Page MenuHomePhabricator
Create Task
Maniphest T203154

addWiki.php is broken due to "Database selection is disallowed to enable reuse."
Closed, ResolvedPublic
Actions

Description

reedy@deploy1001:/srv/mediawiki-staging$ mwscript extensions/WikimediaMaintenance/addWiki.php --wiki=aawiki en wikimedia fixcopyrightwiki fixcopyright.wikimedia.org
Creating database fixcopyrightwiki for en.wikimedia (English)
Initialising tables
Initialising external storage cluster24...
[a86187d6440469406e14829e] [no req]   Wikimedia\Rdbms\DBUnexpectedError from line 375 of /srv/mediawiki-staging/php-1.32.0-wmf.18/includes/libs/rdbms/database/DBConnRef.php: Database selection is disallowed to enable reuse.
Backtrace:
#0 /srv/mediawiki-staging/php-1.32.0-wmf.18/extensions/WikimediaMaintenance/addWiki.php(200): Wikimedia\Rdbms\DBConnRef->selectDB(string)
#1 /srv/mediawiki-staging/php-1.32.0-wmf.18/maintenance/doMaintenance.php(94): AddWiki->execute()
#2 /srv/mediawiki-staging/php-1.32.0-wmf.18/extensions/WikimediaMaintenance/addWiki.php(371): include(string)
#3 /srv/mediawiki-staging/multiversion/MWScript.php(100): include(string)
#4 {main}

Line 200 is the second line here

				$extdb->query( "CREATE DATABASE IF NOT EXISTS $dbName" );
				$extdb->selectDB( $dbName );

Looks to have been caused by @aaron in https://github.com/wikimedia/mediawiki/commit/5891967297a5e1f69925baacbf0c3a4ed13291d6 for T193565

Database selection is disallowed to enable reuse.

Also, that message is awkward to understand

Details

SubjectRepoBranchLines +/-
Fix use of selectDB() on DBConnRef in addWiki.phpmediawiki/extensions/WikimediaMaintenancewmf/1.32.0-wmf.19+12 -3
Revert "rdbms: Disable DBConnRef::selectDB() for sanity"mediawiki/coremaster+1 -2
Fix use of selectDB() on DBConnRef in addWiki.phpmediawiki/extensions/WikimediaMaintenancemaster+12 -3
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Aug 30 2018, 11:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2018, 11:45 AM
Reedy triaged this task as High priority.Aug 30 2018, 11:45 AM
Reedy updated the task description. (Show Details)
Reedy updated the task description. (Show Details)Aug 30 2018, 11:48 AM
Reedy added a subscriber: aaron.
Krenair mentioned this in T147737: Write tests for addWiki that block anything breaking it.Aug 30 2018, 12:16 PM
gerritbot subscribed.Aug 30 2018, 12:30 PM

Change 456382 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Revert "rdbms: Disable DBConnRef::selectDB() for sanity"

https://gerrit.wikimedia.org/r/456382

gerritbot added a project: Patch-For-Review.Aug 30 2018, 12:30 PM
gerritbot added a comment.Aug 31 2018, 7:13 AM

Change 456554 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/WikimediaMaintenance@master] Fix use of selectDB() on DBConnRef in addWiki.php

https://gerrit.wikimedia.org/r/456554

gerritbot added a comment.Aug 31 2018, 11:49 PM

Change 456554 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] Fix use of selectDB() on DBConnRef in addWiki.php

https://gerrit.wikimedia.org/r/456554

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 1 2018, 12:01 AM
gerritbot added a comment.Sep 1 2018, 8:59 PM

Change 457067 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/extensions/WikimediaMaintenance@wmf/1.32.0-wmf.19] Fix use of selectDB() on DBConnRef in addWiki.php

https://gerrit.wikimedia.org/r/457067

gerritbot added a comment.Sep 1 2018, 8:59 PM

Change 456382 abandoned by Krinkle:
Revert "rdbms: Disable DBConnRef::selectDB() for sanity"

Reason:
Deployed.

https://gerrit.wikimedia.org/r/456382

Krinkle assigned this task to aaron.Sep 1 2018, 8:59 PM
Krinkle added a project: Performance-Team.
Krinkle removed a project: MediaWiki-libs-Rdbms.
gerritbot added a comment.Sep 1 2018, 9:44 PM

Change 457067 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@wmf/1.32.0-wmf.19] Fix use of selectDB() on DBConnRef in addWiki.php

https://gerrit.wikimedia.org/r/457067

Stashbot subscribed.Sep 1 2018, 9:47 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-01T21:47:15Z] <krinkle@deploy1001> Synchronized php-1.32.0-wmf.19/extensions/WikimediaMaintenance/: I219882ba09e6a23 - T203154 (duration: 01m 06s)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)); removed MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 1 2018, 10:00 PM
Krinkle closed this task as Resolved.Sep 3 2018, 8:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits