Page MenuHomePhabricator
Create Task
Maniphest T203324

Deprecate loadExitNodes.php
Closed, ResolvedPublic
Actions

Description

0388838d191e converted the file into a pointer to the same file now hosted in the maintenance folder of the extension. Soft-deprecating it now looks like a good idea but maybe a hard deprecation (if we want to remove the file at a later date) would be best.

Details

SubjectRepoBranchLines +/-
Soft-deprecate loadExitNodes.phpmediawiki/extensions/TorBlockmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

MarcoAurelio created this task.Sep 1 2018, 3:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2018, 3:43 PM
gerritbot subscribed.Sep 1 2018, 3:45 PM

Change 456979 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/TorBlock@master] Soft-deprecate loadExitNodes.php

https://gerrit.wikimedia.org/r/456979

gerritbot added a project: Patch-For-Review.Sep 1 2018, 3:45 PM
Jdforrester-WMF subscribed.Sep 7 2018, 10:59 PM

How to check if the crons have been moved over?

Reedy subscribed.Sep 7 2018, 11:01 PM
In T203324#4568381, @Jdforrester-WMF wrote:

How to check if the crons have been moved over?

https://github.com/wikimedia/puppet/blob/b347052863d4d2e87b37d6c2d9f44f833cfd9dc2/modules/mediawiki/manifests/maintenance/tor_exit_node.pp#L4

Jdforrester-WMF added a comment.Sep 7 2018, 11:07 PM

Ta.

Krinkle moved this task from Untriaged to 2018 | MW 1.31 / 1.32 on the Technical-Debt (Deprecation process) board.Sep 19 2018, 7:06 PM
gerritbot added a comment.Sep 22 2018, 12:20 AM

Change 456979 merged by jenkins-bot:
[mediawiki/extensions/TorBlock@master] Soft-deprecate loadExitNodes.php

https://gerrit.wikimedia.org/r/456979

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 22 2018, 1:01 AM
MarcoAurelio closed this task as Resolved.Sep 22 2018, 9:51 AM
MarcoAurelio claimed this task.
MarcoAurelio removed a project: Patch-For-Review.
Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptSep 22 2018, 9:51 AM
MarcoAurelio moved this task from unsorted/backlog to cabinet on the User-MarcoAurelio board.Sep 22 2018, 9:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits