Page MenuHomePhabricator
Create Task
Maniphest T203430

Proofreading is broken on Special:Translate: infinite spinner and JavaScript errors
Closed, ResolvedPublic
Actions

Description

Hi all,

on translatewiki, message "Chargement des messages… " is stuck in an infinite loop with the turning circle and without giving hand back with the list of possible messages to reread (... may be there are none). I must abort the page. Translations are possible from the home page of translatewiki in the normal way, leading to 'Reread' button when there are no more translations (this is ok). This wait was not observed before (... may be because there were always messages left to reread).

https://translatewiki.net/wiki/Special:Translate?action=proofread&group=%21recent&language=fr&filter=translated%7C%21reviewer%3A15345%7C%21last-translator%3A15345

The similar lock situation observed on mediawiki:

https://www.mediawiki.org/w/index.php?title=Special:Translate&group=page-Help%3AExtension%3ATranslate%2FPage+translation+example&action=proofread&filter=translated%7C%21reviewer%3A887141%7C%21last-translator%3A887141&language=fr

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Translatemaster+6 -3Unbreak proofreading
Customize query in gerrit

Event Timeline

Wladek92 created this task.Sep 4 2018, 7:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2018, 7:19 AM
• Nikerabbit added a subscriber: • Nikerabbit.Sep 4 2018, 7:22 AM
Uncaught TypeError: reviewers.indexOf is not a function
    at Proofread.render (ext.translate.proofread.js?53806:87)
    at Proofread.init (ext.translate.proofread.js?53806:40)
    at new Proofread (ext.translate.proofread.js?53806:28)
    at HTMLDivElement.<anonymous> (ext.translate.proofread.js?53806:271)
    at Function.each (jquery.js?09dd6:362)
    at jQuery.fn.init.each (jquery.js?09dd6:157)
    at jQuery.fn.init.$.fn.proofread (ext.translate.proofread.js?53806:265)
    at MessageTable.addProofread (ext.translate.messagetable.js?b09e3:249)
    at MessageTable.add (ext.translate.messagetable.js?b09e3:132)
    at Object.<anonymous> (ext.translate.messagetable.js?b09e3:486)
Wladek92 added a comment.EditedSep 4 2018, 7:24 AM

Similar Nok on wikidata :

https://www.wikidata.org/w/index.php?title=Special:Translate&group=page-Wikidata%3AList+of+properties&action=proofread&filter=translated%7C%21reviewer%3A345727%7C%21last-translator%3A345727&language=fr

• Nikerabbit added a comment.Sep 4 2018, 7:42 AM

About half of the time I also see

Uncaught TypeError: $message.proofread is not a function
    at MessageTable.addProofread (ext.translate.messagetable.js?b09e3:249)
    at MessageTable.add (ext.translate.messagetable.js?b09e3:132)
    at Object.<anonymous> (ext.translate.messagetable.js?b09e3:486)
    at Function.each (jquery.js?09dd6:362)
    at ext.translate.messagetable.js?b09e3:484
    at fire (jquery.js?09dd6:3317)
    at Object.fireWith [as resolveWith] (jquery.js?09dd6:3447)
    at Object.deferred.(/wiki/anonymous function) [as resolve] (https://translatewiki.net/w/resources/lib/jquery/jquery.js?09dd6:3778:36)
    at Object.<anonymous> (index.js?68ce7:276)
    at fire (jquery.js?09dd6:3317)
gerritbot added a subscriber: gerritbot.Sep 4 2018, 8:01 AM

Change 457830 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Unbreak proofreading

https://gerrit.wikimedia.org/r/457830

gerritbot added a project: Patch-For-Review.Sep 4 2018, 8:01 AM
• Nikerabbit renamed this task from Reread impossible : no response from translatewiki/mediawiki when trying to review translations from other users to Proofreading is broken on Special:Translate: infinite spinner and JavaScript errors.Sep 4 2018, 8:11 AM
• Nikerabbit claimed this task.
• Nikerabbit triaged this task as Unbreak Now! priority.
• Nikerabbit added projects: Regression, Language-2018-July-September.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptSep 4 2018, 8:11 AM
• Nikerabbit moved this task from Backlog to In Review on the Language-2018-July-September board.Sep 4 2018, 8:12 AM
Wladek92 added a comment.Sep 4 2018, 8:30 AM

very reactive; super Nike !

gerritbot added a comment.Sep 4 2018, 8:50 AM

Change 457830 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Unbreak proofreading

https://gerrit.wikimedia.org/r/457830

• Petar.petkovic removed a project: Patch-For-Review.Sep 4 2018, 8:51 AM
• Petar.petkovic moved this task from In Review to QA on the Language-2018-July-September board.
• Petar.petkovic removed a subscriber: gerritbot.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 4 2018, 9:00 AM
Liuxinyu970226 added a comment.Sep 4 2018, 2:33 PM

@Nikerabbit this is not only confirmable on twn, but also meta-wiki and mw.org, so why not using MediaWiki-extensions-Translate instead?

• Nikerabbit edited projects, added MediaWiki-extensions-Translate; removed translatewiki.net.Sep 4 2018, 2:39 PM

For anyone wondering, there are two separate issues. My patch fixes both. Only one of the issue is observable on Wikimedia production. I am not planning a SWAT deployment, hoping the MediaWiki train will run on schedule soon.

Wladek92 added a comment.Sep 7 2018, 10:00 AM

Sounds good now from user'point of view. May be conditions are not the same. Thanks all.

• Nikerabbit moved this task from Backlog to tux on the MediaWiki-extensions-Translate board.Sep 7 2018, 10:07 AM
Etonkovidova closed this task as Resolved.Sep 7 2018, 10:38 PM
Etonkovidova added a subscriber: Etonkovidova.

Checked on translatewiki.net and mediawiki (wmf.20) - all looks normal.

Liuxinyu970226 removed a subscriber: Liuxinyu970226.Sep 8 2018, 1:12 AM
• Petar.petkovic moved this task from QA to Done on the Language-2018-July-September board.Sep 11 2018, 7:06 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL