Now we can assert that our libraries aren't screwed with, we should.
[Not really RL, but nowhere better to put it?]
Description
Description
Details
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/core | master | +54 -8 | resources: Add caching for faster runs and offline use |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T203694 Run ForeignResourceManager verification on MediaWiki core commits | |||
| Resolved | Krinkle | T216620 Add error detection to HTTP fetch in foreign resources checker before gzipping |
Event Timeline
Comment Actions
Yeah, sounds good to me!
- The urls are expected to be immutable. The main value we want to get from verifying is to assert that the checksum in our YAML is correct for the given url, and that the extracted files from the remote resource match what was checked into our Git repo. It's less important to verify that the remote copy hasn't changed.
- Without a cache, the job would likely be quite slow. Might be fine if it's a separate job in parallel, but not if adding to the main job.
- Without a cache, the job would be more likely to fail due to random upstream/network issues.
- Regarding cache, probably we can use Castor for this? Alternatively, some generic Squid/http proxy might also work.
Comment Actions
Is there a reason this needs to be something separate and can't be a standard PHPUnit test?
Comment Actions
The "this" as the maintenance script, yes, because it's not (just) a test.
The "this" as the solution for this task to run the verify step in CI, no, that doesn't need to be separate. But, there are considerations that might motivate one to run it separately. Specifically:
But yes, if we do use a cache, and make it work fast, it should be fine to add to the "big" quibble job. But, if we can not make it fast, and/or if the cache is hard to get to work within PHPUnit, then it might make sense to run from a separate job in a way that just invokes the "verify" command from bash.
Comment Actions
Change 498737 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resources: Add caching for faster runs and offline use
Comment Actions
Change 498737 merged by jenkins-bot:
[mediawiki/core@master] resources: Add caching for faster runs and offline use
Comment Actions
Actual Jenkins integration still to be done later.
Could be a PHPUnit structure test, or a separate job. Not sure yet.