Description

Steps to reproduce:

Open a page with VE that has some block nodes in it.
Place your cursor in a paragraph a block node
Mouse over the block node
Press return or backspace

Observe that the light blue highlight stays in the previous position but the block node moves with the cursor.
If you now, click on that blue highlight, it will show the selection highlight along with context menu in that position.

Screen Shot 2018-09-07 at 4.13.34 PM.png (567×1 px, 127 KB)

Screen Shot 2018-09-07 at 4.13.57 PM.png (472×1 px, 116 KB)

Screen Shot 2018-09-07 at 4.33.25 PM.png (364×1 px, 64 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (d2e64ca7b)	mediawiki/extensions/VisualEditor	master	+1 -1
	FocusableNode: Start listening to position events even if not focused	VisualEditor/VisualEditor	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T200387: Fake slugs appearing under each individual images in a gallery
Mentioned Here: rGVEDd2e64ca7b769: Merge "FocusableNode: Start listening to position events even if not focused"
T93660: Highlighting is mis-aligned for inserted template/ inserted media once you open the save dialog and dismiss it

Event Timeline

Ryasmeen created this task.Sep 7 2018, 11:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 7 2018, 11:35 PM

Possibly the same as, or related to, T93660? I also could've sworn I saw a bug almost exactly like this related to moving infoboxes around, but I can't find that right now...

Needs evaluation by engineers.

Esanders renamed this task from Weird highlight behavior for all block nodes to Highlights not updated when document modified.Sep 12 2018, 12:20 PM

Esanders updated the task description. (Show Details)

Esanders renamed this task from Highlights not updated when document modified to Hover highlights not updated when document modified.Sep 12 2018, 12:35 PM

Change 460009 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] FocusableNode: Start listening to position events even if not focused

https://gerrit.wikimedia.org/r/460009

gerritbot added a project: Patch-For-Review.Sep 12 2018, 12:36 PM

Esanders claimed this task.Sep 12 2018, 12:36 PM

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Jdforrester-WMF added projects: VisualEditor-ContentEditable, VisualEditor-EditingTools.Sep 12 2018, 11:05 PM

• matmarex mentioned this in T200387: Fake slugs appearing under each individual images in a gallery.Sep 13 2018, 5:52 AM

Change 460009 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] FocusableNode: Start listening to position events even if not focused

https://gerrit.wikimedia.org/r/460009

• matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Sep 13 2018, 1:13 PM

Change 460404 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d2e64ca7b)

https://gerrit.wikimedia.org/r/460404

Change 460404 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d2e64ca7b)

https://gerrit.wikimedia.org/r/460404

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)); removed Patch-For-Review.Sep 13 2018, 7:41 PM

Ryasmeen added a project: Verified.Sep 13 2018, 10:17 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

• Deskana closed this task as Resolved.Sep 28 2018, 3:31 PM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 28 2018, 3:31 PM

• matmarex merged a task: T168633: Template highlighting gets stuck when template is shifted (but the highlighting corrects itself as soon as you move the mouse).Nov 2 2018, 1:55 PM

• matmarex added subscribers: • Elitre, SUM1.

• Elitre unsubscribed.Nov 8 2018, 4:57 PM

	F25700430: Screen Shot 2018-09-07 at 4.13.34 PM.png
	Sep 7 2018, 11:35 PM

	F25700438: Screen Shot 2018-09-07 at 4.13.57 PM.png
	Sep 7 2018, 11:35 PM

	F25700449: Screen Shot 2018-09-07 at 4.33.25 PM.png
	Sep 7 2018, 11:35 PM

Hover highlights not updated when document modifiedClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Hover highlights not updated when document modified
Closed, ResolvedPublic
Actions