Page MenuHomePhabricator

The upload form should not be visible or linked to for users who don't have the edit right
Closed, ResolvedPublic

Description

You need the edit right to upload files. Assuming this is intended behavior, the upload form should not load if you don't have the edit right, and there should not be a link on the toolbox or in Special:Specialpages.


Version: 1.15.x
Severity: minor

Details

Reference
bz18408

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:33 PM
bzimport set Reference to bz18408.
bzimport added a subscriber: Unknown Object (MLST).

From my understanding of the user rights [1], The edit shouldn't effect upload permissions, the upload right should be the one thats effecting the permission to upload and thats what should be getting checked against.

[1]. http://www.mediawiki.org/wiki/Manual:User_rights

Bryan.TongMinh wrote:

(In reply to comment #1)

From my understanding of the user rights [1], The edit shouldn't effect upload
permissions, the upload right should be the one thats effecting the permission
to upload and thats what should be getting checked against.

[1]. http://www.mediawiki.org/wiki/Manual:User_rights

Uploading requires edit, create and upload rights.

Bryan.TongMinh wrote:

Fixed in r65818.

heugabel wrote:

(In reply to comment #2)

(In reply to comment #1)

From my understanding of the user rights [1], The edit shouldn't effect upload
permissions, the upload right should be the one thats effecting the permission
to upload and thats what should be getting checked against.

[1]. http://www.mediawiki.org/wiki/Manual:User_rights

Uploading requires edit, create and upload rights.

not working, i can´t acess the upload page :-(

Bryan.TongMinh wrote:

Fixed in r65898.

heugabel wrote:

You must set a submission callback

Backtrace:

#0 /home/xxx/public_html/wiki/includes/specials/SpecialUpload.php(1011): HTMLForm->show()
#1 /home/xxx/public_html/wiki/includes/specials/SpecialUpload.php(200): UploadForm->show()
#2 /home/xxx/public_html/wiki/includes/specials/SpecialUpload.php(179): SpecialUpload->showUploadForm(Object(UploadForm))
#3 /home/xxx/public_html/wiki/includes/SpecialPage.php(572): SpecialUpload->execute(NULL)
#4 /home/xxx/public_html/wiki/includes/Wiki.php(259): SpecialPage::executePath(Object(Title))
#5 /home/xxx/public_html/wiki/includes/Wiki.php(67): MediaWiki->handleSpecialCases(Object(Title), Object(OutputPage), Object(WebRequest))
#6 /home/xxx/public_html/wiki/index.php(116): MediaWiki->performRequestForTitle(Object(Title), NULL, Object(OutputPage), Object(User), Object(WebRequest))
#7 /home/xxx/public_html/vbseo.php(1577): require('/home/xxx/...')
#8 {main}

what? i cant understand this :-) sorry

This is related to r65841 instead.