Page MenuHomePhabricator

type=frame images are not resizeable, VE makes user think they are
Closed, ResolvedPublic

Description

Source: https://www.mediawiki.org/wiki/OOUI/Widgets/Icons,_Indicators,_and_Labels

When I try to resize the retina image File:WidgetsIndicators.png on the page in VE, it shows me the image in the right size. After publishing I'm confronted with the original size again.

Event Timeline

The dialog issue is separate, and really should've been fixed by T202587 :/

Esanders renamed this task from Image is shown in correct size after resizing, but then looses its attributes with publishing to type=frame images are not resizeable, VE makes user think they are.Sep 24 2018, 1:41 PM

The image resize problem is because it is type=frame, not type=thumb. We should either disable the resize widget when type=frame, or automatically switch to type=thumb when a non-default size is entered.

Looks like we already have code to disable the size widget when type=frame, but it is not called on load, only when the dropdown is changed.

Change 462476 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Create new #updateDisabled method to handle disabled state of sub-widgets

https://gerrit.wikimedia.org/r/462476

Change 462484 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Change type from 'frame' to 'thumb' when resizing

https://gerrit.wikimedia.org/r/462484

The dialog issue is separate, and really should've been fixed by T202587 :/

Looks like the edit was only made 2 days after that was merged, so I've removed that part of the ticket as duplicate.

Change 462476 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] MediaSizeWidget: Add #updateDisabled() for disableable sub-widgets

https://gerrit.wikimedia.org/r/462476

Change 462484 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Change type from 'frame' to 'thumb' when resizing

https://gerrit.wikimedia.org/r/462484

Change 462733 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2f27b1a2c)

https://gerrit.wikimedia.org/r/462733

Change 462733 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2f27b1a2c)

https://gerrit.wikimedia.org/r/462733

Deskana triaged this task as Medium priority.