Page MenuHomePhabricator

VisualEditor (NWE) doesn't exit cleanly when clicking the namespace tab on a discussion page
Closed, ResolvedPublic

Description

VisualEditor (NWE) doesn't exit cleanly when clicking the namespace tab on a discussion page.

Ok, so I managed to pin down why the editor save box doesn't show up sometimes. When editing a non-talk page, clicking the tab for that page triggers the editor save box (e.g. "read" tab on an article, "project page" tab on project namespace, etc.), but clicking anything that would change the URL (talk page, main page, your user page, etc.) triggers the browser's unsaved changes prompt (so no ability to discard).
Conversely, when editing a talk page, clicking the talk page tab doesn't trigger the editor save box, but the browser's unsaved changes prompt, just like clicking away would. Maybe this should be changed so clicking the talk page tab works the same as the main tab does when editing.

Event Timeline

matmarex created this task.Sep 13 2018, 8:30 AM
Restricted Application added a project: VisualEditor. · View Herald TranscriptSep 13 2018, 8:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 460283 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.DesktopArticleTarget: Handle deactivate on namespace tab when it's a talk namespace

https://gerrit.wikimedia.org/r/460283

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders assigned this task to matmarex.Sep 13 2018, 5:55 PM

Change 460283 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.DesktopArticleTarget: Handle deactivate on namespace tab when it's a talk namespace

https://gerrit.wikimedia.org/r/460283

Deskana closed this task as Resolved.Sep 27 2018, 1:48 PM
Deskana triaged this task as Normal priority.