| Lucas_Werkmeister_WMDE | |
| Sep 18 2018, 2:06 PM |
| F27144472: Screenshot_2018-11-09 Grafana - Wikidata Quality.png | |
| Nov 9 2018, 3:32 PM |
We want to track some more things in Grafana. At least:
Code to look at:
LoggingHelper.php
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T244043 suggestions and possible decisions from the 2020 report on Property constraints | |||
| Open | None | T192565 Find constraint violations | |||
| Open | None | T201150 Regularly run constraint checks for all items | |||
| Resolved | Ladsgroup | T204031 Deploy regular running of wikidata constraint checks using the job queue | |||
| Resolved | Lydia_Pintscher | T204022 Add functionality to run QualityConstraint checks on an entity after every edit | |||
| Resolved | Lucas_Werkmeister_WMDE | T204715 Add more tracking for constraint checks |
Change 463936 had a related patch set uploaded (by Matthias Geisler; owner: Matthias Geisler):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add more tracking for constraint checks
Change 471777 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Track more detailed timings in TypeCheckerHelper
Change 463936 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add more tracking for constraint checks
Change 471777 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Track more detailed timings in TypeCheckerHelper
I’ve added the type check timings to the wikidata-quality board now. Here’s a screenshot of the current state:
My interpretation of this is that 60-70% of type checks already happen in PHP, and they still take very little time compared to the SPARQL type checks, even the ones that end up falling back to SPARQL. So we might want to change the configuration to do more checks in PHP (i. e., let PHP check more entities before falling back to SPARQL).
Total runtime for all constraint checks of an entity isn’t on the board yet, I’m not sure where to put it.
Total runtime for all constraint checks of an entity isn’t on the board yet, I’m not sure where to put it.
I added a simple graph for this just so that it is displayed and can be watched even if this stuff moves around later down the road.
So we might want to change the configuration to do more checks in PHP (i. e., let PHP check more entities before falling back to SPARQL).
See T209504: Perform more constraint type checks in PHP before falling back to SPARQL.