Maniphest T204795

EchoNotificationController throws "Call to a member function isMinor() on a non-object" after Special:Undelete action
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: W6GslwrAIEMAACfCmK8AAAAY

message

[{exception_id}] {exception_url}   BadMethodCallException from line 107 of /srv/mediawiki/php-1.32.0-wmf.20/extensions/Echo/includes/controller/NotificationController.php: Call to a member function isMinor() on a non-object (null)

stacktrace

#0 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Echo/includes/model/Event.php(168): EchoNotificationController::notify(EchoEvent, boolean)
#1 /srv/mediawiki/php-1.32.0-wmf.20/extensions/Echo/includes/EchoHooks.php(797): EchoEvent::create(array)
#2 /srv/mediawiki/php-1.32.0-wmf.20/includes/Hooks.php(174): EchoHooks::onLinksUpdateAfterInsert(LinksUpdate, string, array)
#3 /srv/mediawiki/php-1.32.0-wmf.20/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#4 /srv/mediawiki/php-1.32.0-wmf.20/includes/deferred/LinksUpdate.php(490): Hooks::run(string, array)
#5 /srv/mediawiki/php-1.32.0-wmf.20/includes/deferred/LinksUpdate.php(220): LinksUpdate->incrTableUpdate(string, string, array, array)
#6 /srv/mediawiki/php-1.32.0-wmf.20/includes/deferred/LinksUpdate.php(175): LinksUpdate->doIncrementalUpdate()
#7 /srv/mediawiki/php-1.32.0-wmf.20/includes/deferred/DeferredUpdates.php(268): LinksUpdate->doUpdate()
#8 /srv/mediawiki/php-1.32.0-wmf.20/includes/deferred/DeferredUpdates.php(214): DeferredUpdates::runUpdate(LinksUpdate, Wikimedia\Rdbms\LBFactoryMulti, string, integer)
#9 /srv/mediawiki/php-1.32.0-wmf.20/includes/deferred/DeferredUpdates.php(134): DeferredUpdates::execute(array, string, integer)
#10 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(914): DeferredUpdates::doUpdates(string)
#11 /srv/mediawiki/php-1.32.0-wmf.20/includes/MediaWiki.php(734): MediaWiki->restInPeace(string, boolean)
#12 [internal function]: Closure$MediaWiki::doPostOutputShutdown()

Source: https://gerrit.wikimedia.org/g/mediawiki/extensions/Echo/+/be440a475cafdb9914dcca812a89ba3a55db15d0/includes/controller/NotificationController.php#107

Notes

This exception was recorded 18 times in Logtash over the last 7 days (1.32.0-wmf.20 an 1.32.0-wmf.19) on multiple wikis (including en.wikipedia.org, ar.wikipedia.org, fr.wikipedia.org).

Maybe related:

T202920

Details

	Subject	Repo	Branch	Lines +/-
	Handle revision not found	mediawiki/extensions/Echo	master	+37 -9

Customize query in gerrit

Related Objects

Mentioned In: T219155: Fatal Error when trying to read notifications: Call to a member function getComment() on null
Mentioned Here: T202920: null argument on DifferenceEngine->generateContentDiffBody() on Special:Undelete

Event Timeline

Krinkle created this task.Sep 19 2018, 2:16 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 19 2018, 2:16 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Krinkle moved this task from Untriaged to Older on the Wikimedia-production-error board.Sep 19 2018, 2:16 AM

Still seen on 1.32.0-wmf.23.

Change 464813 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/Echo@master] Handle revision not found

https://gerrit.wikimedia.org/r/464813

gerritbot added a project: Patch-For-Review.Oct 5 2018, 1:07 PM

SBisson claimed this task.Oct 5 2018, 1:08 PM

SBisson edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

SBisson moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 464813 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Handle revision not found

https://gerrit.wikimedia.org/r/464813

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 5 2018, 11:00 PM

Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 9 2018, 8:59 PM

Krinkle moved this task from Older to Resolved on the Wikimedia-production-error board.Oct 10 2018, 7:24 PM

Krinkle removed a project: Patch-For-Review.Oct 10 2018, 9:04 PM

Added to the list of tasks to be monitored after deployment.

Krinkle mentioned this in T219155: Fatal Error when trying to read notifications: Call to a member function getComment() on null.Mar 29 2019, 2:31 AM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM

EchoNotificationController throws "Call to a member function isMinor() on a non-object" after Special:Undelete action Closed, ResolvedPublicPRODUCTION ERRORActions