| matmarex | |
| Sep 27 2018, 4:45 PM |
| F26220980: image.png | |
| Sep 27 2018, 4:45 PM |
There is a "Make full size" button in the media dialog:
I propose that we remove it.
Change 463310 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[VisualEditor/VisualEditor@master] ve.ui.MediaSizeWidget: Remove "Make full size" button
I wrote the patch first, but then decided to file this task and ask if we should actually do this, just in case there is a reason for this button's existence.
Makes sense to me. As far as I can see, other than the media dialog, only the graph dialog uses the media size widget, and it configures it not to have the "full size" button.
Any thoughts @Esanders @Deskana @Whatamidoing-WMF ?
@Tchanders Nice timing on the ping! I was just looking at this. I think this can be removed for the reasons that @matmarex pointed out above.
Change 463310 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ui.MediaSizeWidget: Remove "Make full size" button
Change 464018 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1191c3687)
Change 464018 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1191c3687)