Page MenuHomePhabricator
Create Task
Maniphest T206002

Target widget looks confusing without an outline
Closed, ResolvedPublic
Actions

Description

It is difficult to recognise the target widget as an editing area, because it has no outline.

From T190885:

Screen Shot 2018-10-01 at 2.31.49 PM.png (226×1 px, 30 KB)

Details

SubjectRepoBranchLines +/-
Fix OOUI->MW theme mappings in extension.jsonmediawiki/extensions/VisualEditormaster+9 -0
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Oct 2 2018, 6:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 2 2018, 6:02 PM
Tchanders mentioned this in T190885: Re-evaluate mobile editing for images .Oct 2 2018, 6:06 PM
Tchanders moved this task from To Triage to FY 18-19 Q3/Q4 on the VisualEditor board.Oct 3 2018, 2:43 PM
JTannerWMF moved this task from FY 18-19 Q3/Q4 to Current work on the VisualEditor board.Oct 3 2018, 4:59 PM
JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders subscribed.Oct 3 2018, 5:36 PM

TargetWidget borders are defined by OOUI skin (in src/themes/wikimediaui.css & src/themes/apex.css), but no file is loaded for Minerva. This should be pretty trivial to fix in extension.json.

Esanders claimed this task.Oct 3 2018, 9:20 PM
Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.
gerritbot subscribed.Oct 3 2018, 9:24 PM

Change 464434 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix OOUI->MW theme mappings in extension.json

https://gerrit.wikimedia.org/r/464434

gerritbot added a project: Patch-For-Review.Oct 3 2018, 9:24 PM
Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Oct 3 2018, 9:45 PM
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki; removed Patch-For-Review.Oct 3 2018, 9:48 PM
Jdforrester-WMF moved this task from Code review to QA on the VisualEditor (Current work) board.
gerritbot added a comment.Oct 3 2018, 10:09 PM

Change 464434 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix OOUI->MW theme mappings in extension.json

https://gerrit.wikimedia.org/r/464434

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 3 2018, 11:01 PM
Ryasmeen added a project: Verified.Oct 4 2018, 8:36 PM
Ryasmeen awarded a token.
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• Deskana added a project: Editing Q2 2018-19 mobile improvements.Oct 11 2018, 3:13 PM
• Deskana subscribed.

Probably counts as mobile-related given that the above comments indicate it improves the editing environment in Minerva...

• Deskana closed this task as Resolved.Oct 11 2018, 3:13 PM
• Deskana triaged this task as Medium priority.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits