Maniphest T206629

Diffing revisions before & after wikidata/mediainfo things got added fail
Closed, ResolvedPublic
Actions

Description

Reproduce: upload image & add MediaInfo entities.
Go to history, select first revision (from when there was no MediaInfo data yet)
Click "edit" - should take you to "restore" and show a diff.
Instead, you'll get this error:

[f36b83af22c5a24fe0efc0db] /w/index.php?title=File:a-new-file.jpg&action=mcrrestore&restore=575 RuntimeException from line 147 of /vagrant/mediawiki/extensions/Wikibase/repo/includes/Content/EntityContent.php: EntityContent was constructed without an EntityId!

Backtrace:

#0 /vagrant/mediawiki/extensions/Wikibase/repo/includes/Content/EntityContent.php(457): Wikibase\EntityContent->getEntityId()
#1 /vagrant/mediawiki/extensions/Wikibase/repo/includes/Content/EntityContent.php(572): Wikibase\EntityContent->getRedirectData()
#2 /vagrant/mediawiki/extensions/Wikibase/repo/includes/Diff/EntityContentDiffView.php(135): Wikibase\EntityContent->getDiff(Wikibase\MediaInfo\Content\MediaInfoContent)
#3 /vagrant/mediawiki/includes/diff/DifferenceEngineSlotDiffRenderer.php(58): Wikibase\Repo\Diff\EntityContentDiffView->generateContentDiffBody(Wikibase\MediaInfo\Content\MediaInfoContent, Wikibase\MediaInfo\Content\MediaInfoContent)
#4 /vagrant/mediawiki/includes/diff/DifferenceEngine.php(1056): DifferenceEngineSlotDiffRenderer->getDiff(Wikibase\MediaInfo\Content\MediaInfoContent, Wikibase\MediaInfo\Content\MediaInfoContent)
#5 /vagrant/mediawiki/includes/diff/DifferenceEngine.php(974): DifferenceEngine->getDiffBody()
#6 /vagrant/mediawiki/includes/actions/McrUndoAction.php(242): DifferenceEngine->getDiff(string, string)
#7 /vagrant/mediawiki/includes/actions/McrUndoAction.php(363): McrUndoAction->generateDiffOrPreview()
#8 /vagrant/mediawiki/includes/htmlform/fields/HTMLInfoField.php(25): McrUndoAction->{closure}(array)
#9 /vagrant/mediawiki/includes/htmlform/HTMLForm.php(1670): HTMLInfoField->getDefault()
#10 /vagrant/mediawiki/includes/htmlform/HTMLForm.php(1254): HTMLForm->displaySection(array, string)
#11 /vagrant/mediawiki/includes/htmlform/OOUIHTMLForm.php(252): HTMLForm->getBody()
#12 /vagrant/mediawiki/includes/htmlform/HTMLForm.php(1044): OOUIHTMLForm->getBody()
#13 /vagrant/mediawiki/includes/htmlform/HTMLForm.php(1023): HTMLForm->getHTML(boolean)
#14 /vagrant/mediawiki/includes/htmlform/HTMLForm.php(577): HTMLForm->displayForm(boolean)
#15 /vagrant/mediawiki/includes/actions/FormAction.php(143): HTMLForm->show()
#16 /vagrant/mediawiki/includes/actions/McrUndoAction.php(90): FormAction->show()
#17 /vagrant/mediawiki/includes/MediaWiki.php(506): McrUndoAction->show()
#18 /vagrant/mediawiki/includes/MediaWiki.php(294): MediaWiki->performAction(ImagePage, Title)
#19 /vagrant/mediawiki/includes/MediaWiki.php(873): MediaWiki->performRequest()
#20 /vagrant/mediawiki/includes/MediaWiki.php(530): MediaWiki->main()
#21 /vagrant/mediawiki/index.php(42): MediaWiki->run()
#22 /var/www/w/index.php(5): require(string)
#23 {main}

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/Wikibase	master	+44 -10	Handle diffs for EntityContents without handler

Customize query in gerrit

Related Objects

Mentioned In: T205732: Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions)

Event Timeline

matthiasmullie created this task.Oct 10 2018, 2:28 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptOct 10 2018, 2:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 465435 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/Wikibase@master] Handle diffs for EntityContents without handler

https://gerrit.wikimedia.org/r/465435

gerritbot added a project: Patch-For-Review.Oct 10 2018, 2:29 PM

matthiasmullie moved this task from To Do to Code Review on the Multimedia-Team-Working-Board board.Oct 10 2018, 2:29 PM

matthiasmullie moved this task from To Do to Doing on the Structured Data Engineering board.

Jdforrester-WMF mentioned this in T205732: Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions).Oct 10 2018, 3:01 PM

Change 465435 had a related patch set uploaded (by Jforrester; owner: Matthias Mullie):
[mediawiki/extensions/Wikibase@master] Handle diffs for EntityContents without handler

https://gerrit.wikimedia.org/r/465435

Change 465435 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Handle diffs for EntityContents without handler

https://gerrit.wikimedia.org/r/465435

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.1; 2018-10-23).Oct 17 2018, 3:00 AM

Jdforrester-WMF removed a project: Patch-For-Review.Oct 17 2018, 3:11 AM

Jdforrester-WMF moved this task from Doing to Verify on Production on the Structured Data Engineering board.

Cparle moved this task from Code Review to Needs QA on the Multimedia-Team-Working-Board board.Oct 17 2018, 4:17 PM

Cparle moved this task from Needs QA to Ready for Production Testing on the Multimedia-Team-Working-Board board.Oct 17 2018, 4:20 PM

Ramsey-WMF triaged this task as High priority.Oct 17 2018, 5:08 PM

Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.