Page MenuHomePhabricator

MediaWiki\MassMessage\MassMessageJobTest::testLQTMessageSending fails in PHP 7.2
Closed, ResolvedPublic

Description

22:23:31 1) MediaWiki\MassMessage\MassMessageJobTest::testLQTMessageSending
22:23:31 count(): Parameter must be an array or an object that implements Countable
22:23:31 
22:23:31 /workspace/src/extensions/LiquidThreads/api/ApiThreadAction.php:233
22:23:31 /workspace/src/extensions/LiquidThreads/api/ApiThreadAction.php:55
22:23:31 /workspace/src/includes/api/ApiMain.php:1587
22:23:31 /workspace/src/includes/api/ApiMain.php:500
22:23:31 /workspace/src/extensions/MassMessage/includes/job/MassMessageJob.php:327
22:23:31 /workspace/src/extensions/MassMessage/includes/job/MassMessageJob.php:249
22:23:31 /workspace/src/extensions/MassMessage/includes/job/MassMessageJob.php:198
22:23:31 /workspace/src/extensions/MassMessage/includes/job/MassMessageJob.php:59
22:23:31 /workspace/src/extensions/MassMessage/tests/phpunit/job/MassMessageJobTest.php:29
22:23:31 /workspace/src/extensions/MassMessage/tests/phpunit/job/MassMessageJobTest.php:70
22:23:31 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
22:23:31 /workspace/src/maintenance/doMaintenance.php:94

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/299/consoleFull

Can be verified by commenting "check experimental" on a patch to trigger the PHP 7.2 job.

Event Timeline

Legoktm created this task.Oct 13 2018, 6:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2018, 6:06 AM

Change 467071 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/LiquidThreads@master] Fix failing test in MassMessage extension

https://gerrit.wikimedia.org/r/467071

xSavitar claimed this task.Oct 13 2018, 9:12 AM
xSavitar added a project: User-xSavitar.
xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.

Change 467071 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Fix testLQTMessageSending failing test in MassMessage

https://gerrit.wikimedia.org/r/467071

Change 467674 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/LiquidThreads@master] Fix and revert for Ia968cdaa936fddb577071af072fa44260a2dbca1

https://gerrit.wikimedia.org/r/467674

Change 467674 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Fix and revert for Ia968cdaa936fddb577071af072fa44260a2dbca1

https://gerrit.wikimedia.org/r/467674