Page MenuHomePhabricator
Create Task
Maniphest T206901

MediaWiki\MassMessage\MassMessageJobTest::testLQTMessageSending fails in PHP 7.2
Closed, ResolvedPublic
Actions

Description

22:23:31 1) MediaWiki\MassMessage\MassMessageJobTest::testLQTMessageSending
22:23:31 count(): Parameter must be an array or an object that implements Countable
22:23:31 
22:23:31 /workspace/src/extensions/LiquidThreads/api/ApiThreadAction.php:233
22:23:31 /workspace/src/extensions/LiquidThreads/api/ApiThreadAction.php:55
22:23:31 /workspace/src/includes/api/ApiMain.php:1587
22:23:31 /workspace/src/includes/api/ApiMain.php:500
22:23:31 /workspace/src/extensions/MassMessage/includes/job/MassMessageJob.php:327
22:23:31 /workspace/src/extensions/MassMessage/includes/job/MassMessageJob.php:249
22:23:31 /workspace/src/extensions/MassMessage/includes/job/MassMessageJob.php:198
22:23:31 /workspace/src/extensions/MassMessage/includes/job/MassMessageJob.php:59
22:23:31 /workspace/src/extensions/MassMessage/tests/phpunit/job/MassMessageJobTest.php:29
22:23:31 /workspace/src/extensions/MassMessage/tests/phpunit/job/MassMessageJobTest.php:70
22:23:31 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
22:23:31 /workspace/src/maintenance/doMaintenance.php:94

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/299/consoleFull

Can be verified by commenting "check experimental" on a patch to trigger the PHP 7.2 job.

Details

SubjectRepoBranchLines +/-
Fix testLQTMessageSending failing test in MassMessagemediawiki/extensions/LiquidThreadsREL1_31+2 -2
Fix and revert for Ia968cdaa936fddb577071af072fa44260a2dbca1mediawiki/extensions/LiquidThreadsmaster+2 -3
Fix testLQTMessageSending failing test in MassMessagemediawiki/extensions/LiquidThreadsmaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Oct 13 2018, 6:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2018, 6:06 AM
Legoktm added a parent task: T204884: Run MediaWiki tests on PHP 7.3.Oct 13 2018, 6:12 AM
Legoktm moved this task from Untriaged to Wikimedia production on the PHP 7.2 support board.
gerritbot subscribed.Oct 13 2018, 9:08 AM

Change 467071 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/LiquidThreads@master] Fix failing test in MassMessage extension

https://gerrit.wikimedia.org/r/467071

gerritbot added a project: Patch-For-Review.Oct 13 2018, 9:08 AM
xSavitar claimed this task.Oct 13 2018, 9:12 AM
xSavitar added a project: User-xSavitar.
xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.
Legoktm added a project: MediaWiki-extensions-LiquidThreads.Oct 13 2018, 4:32 PM
xSavitar moved this task from Backlog to Doing (In progress) on the MassMessage board.Oct 14 2018, 1:37 PM
gerritbot added a comment.Oct 15 2018, 5:31 PM

Change 467071 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Fix testLQTMessageSending failing test in MassMessage

https://gerrit.wikimedia.org/r/467071

Jdforrester-WMF closed this task as Resolved.Oct 15 2018, 5:41 PM
Jdforrester-WMF subscribed.

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/1366/console in MM now passes.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 15 2018, 6:00 PM
gerritbot added a comment.Oct 16 2018, 12:36 PM

Change 467674 had a related patch set uploaded (by D3r1ck01; owner: Alangi Derick):
[mediawiki/extensions/LiquidThreads@master] Fix and revert for Ia968cdaa936fddb577071af072fa44260a2dbca1

https://gerrit.wikimedia.org/r/467674

gerritbot added a comment.Oct 17 2018, 7:35 AM

Change 467674 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Fix and revert for Ia968cdaa936fddb577071af072fa44260a2dbca1

https://gerrit.wikimedia.org/r/467674

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.1; 2018-10-23).Oct 17 2018, 8:00 AM
gerritbot added a comment.Jan 2 2021, 10:00 AM

Change 653158 had a related patch set uploaded (by Umherirrender; owner: Alangi Derick):
[mediawiki/extensions/LiquidThreads@REL1_31] Fix testLQTMessageSending failing test in MassMessage

https://gerrit.wikimedia.org/r/653158

gerritbot added a comment.Jan 2 2021, 10:10 AM

Change 653158 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@REL1_31] Fix testLQTMessageSending failing test in MassMessage

https://gerrit.wikimedia.org/r/653158

Maintenance_bot removed a project: Patch-For-Review.Jan 2 2021, 10:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL