Page MenuHomePhabricator
Create Task
Maniphest T204884

Run MediaWiki tests on PHP 7.3
Closed, ResolvedPublic
Actions

Description

Prior art: T144962

We need to add PHP 7.3 jobs for MediaWiki CI, in anticipation for Wikimedia production and the rest of the world moving to 7.3

Details

SubjectRepoBranchLines +/-
layout: [quibble] Move all PHP 7.3 jobs from experimental to votingintegration/configmaster+17 -11
.travis.yml: Don't allow failures for PHP 7.3 any moremediawiki/coremaster+0 -2
Make PHP 7.2 MediaWiki tests votingintegration/configmaster+32 -7
Add experimental Quibble PHP 7.3 jobsintegration/configmaster+14 -0
Add Quibble PHP 7.3 imageintegration/configmaster+62 -0
travis: Remove PHP 7.2 from allowed failuresmediawiki/coremaster+0 -1
Add quibble-stretch-php72 imageintegration/configmaster+62 -0
Make MediaWiki PHP 7.1 tests votingintegration/configmaster+30 -15
Add quibble php71 jobsintegration/configmaster+11 -0
Add quibble-stretch-php71 docker imageintegration/configmaster+62 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReedyT204884 Run MediaWiki tests on PHP 7.3
 ResolvedJdforrester-WMFT205957 TimeParsingTest::testSeconds2NptFormat fails on PHP 7.1
 ResolvedAddshoreT205958 Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1
 ResolvedLadsgroupT206100 Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest fails on PHP 7.1
 ResolvedthiemowmdeT206281 Wikibase\MediaInfo\Tests\MediaWiki\View\FilePageMediaInfoViewTest::testGetHtmlException fails on PHP 7.1
 ResolvedMaxSemT206293 Kartographer tests are failing on PHP 7.1
 ResolvedmatmarexT206287 TemplateData tests are failing on PHP 7.1
 ResolvedthiemowmdeT206286 FileImporter tests are failing on PHP 7.1
 ResolvedJdforrester-WMFT206297 Popups tests are failing on PHP 7.1
 ResolvedLegoktmT206541 EchoUserNotificationGatewayTest::testMarkAllRead fails count(): Parameter must be an array or an object that implements Countable
 ResolvedLegoktmT206899 CirrusSearch\Test\RequestLoggerTest::testRequestLogging fails on PHP 7.2 due to each()
 ResolvedLegoktmT190024 Elastica 5.3 uses the each keyword which is deprecated in PHP 7.2
ResolvedBPirkleT206900 CollaborationHubContentTest::testGetMembersBlock fails on PHP 7.2
 ResolvedKrinkleT196412 Fix "PHP Warning: count(): Parameter must be an array or Countable" in FlaggedRevs/backend/FRUserActivity.php
 ResolvedxSavitarT206901 MediaWiki\MassMessage\MassMessageJobTest::testLQTMessageSending fails in PHP 7.2
 ResolvedkostajhT206583 Flow\Tests\Import\TalkpageImportOperationTest::testImportDoesntCompletelyFail fails on PHP 7.2
 ResolvedKrinkleT202087 TemplateData emits count() parameter warning on PHP7.2
 Resolved• santhoshT207100 LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3
 ResolvedRazeSoldierT207122 Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3
 ResolvedAnomieT207112 session_id(): Cannot change session id when session is active test failures on PHP 7.3
 ResolvedRazeSoldierT209756 IPSet tests fail on PHP 7.3

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
CCicalese_WMF edited projects, added Platform Team Legacy (Designing); removed Core-Platform-Team-Old.Oct 1 2018, 7:40 PM
CCicalese_WMF added a project: Core Platform Team Goals (PHP7 (TEC4)).Oct 2 2018, 12:17 AM
CCicalese_WMF edited projects, added Platform Engineering (PHP7 (TEC4)); removed Core Platform Team Goals (PHP7 (TEC4)).Oct 2 2018, 2:17 AM
gerritbot subscribed.Oct 2 2018, 7:36 AM

Change 463903 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[integration/config@master] Add quibble-stretch-php71 docker image

https://gerrit.wikimedia.org/r/463903

gerritbot added a project: Patch-For-Review.Oct 2 2018, 7:36 AM

Change 463903 merged by jenkins-bot:
[integration/config@master] Add quibble-stretch-php71 docker image

https://gerrit.wikimedia.org/r/463903

gerritbot added a comment.Oct 2 2018, 7:45 AM

Change 463905 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[integration/config@master] Add quibble php71 jobs

https://gerrit.wikimedia.org/r/463905

gerritbot added a comment.Oct 2 2018, 7:58 AM

Change 463905 merged by jenkins-bot:
[integration/config@master] Add quibble php71 jobs

https://gerrit.wikimedia.org/r/463905

Legoktm added subtasks: T205957: TimeParsingTest::testSeconds2NptFormat fails on PHP 7.1, T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1.Oct 2 2018, 8:13 AM
Legoktm added a comment.Oct 2 2018, 8:15 AM

MediaWiki core had a clean test run on 7.1. Extension gate ran into two errors in the databaseless tests before aborting (blockers filed).

CCicalese_WMF moved this task from Inbox to Doing on the Platform Team Legacy (Designing) board.Oct 2 2018, 6:17 PM
Legoktm closed subtask T205957: TimeParsingTest::testSeconds2NptFormat fails on PHP 7.1 as Resolved.Oct 2 2018, 7:02 PM
Legoktm added a subtask: T206100: Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest fails on PHP 7.1.Oct 3 2018, 5:45 AM
Legoktm added a subtask: T206281: Wikibase\MediaInfo\Tests\MediaWiki\View\FilePageMediaInfoViewTest::testGetHtmlException fails on PHP 7.1.Oct 5 2018, 2:28 AM
Legoktm added subtasks: T206293: Kartographer tests are failing on PHP 7.1, T206287: TemplateData tests are failing on PHP 7.1, T206286: FileImporter tests are failing on PHP 7.1.Oct 5 2018, 5:14 AM
Legoktm added a subtask: T206297: Popups tests are failing on PHP 7.1.Oct 5 2018, 6:11 AM
Jdforrester-WMF closed subtask T206287: TemplateData tests are failing on PHP 7.1 as Resolved.Oct 5 2018, 6:37 PM
Legoktm closed subtask T206297: Popups tests are failing on PHP 7.1 as Resolved.Oct 6 2018, 5:50 AM
thiemowmde closed subtask T206286: FileImporter tests are failing on PHP 7.1 as Resolved.Oct 8 2018, 9:21 AM
Jdforrester-WMF changed the status of subtask T206281: Wikibase\MediaInfo\Tests\MediaWiki\View\FilePageMediaInfoViewTest::testGetHtmlException fails on PHP 7.1 from Open to Stalled.Oct 9 2018, 3:58 PM
Legoktm closed subtask T206281: Wikibase\MediaInfo\Tests\MediaWiki\View\FilePageMediaInfoViewTest::testGetHtmlException fails on PHP 7.1 as Resolved.Oct 9 2018, 5:11 PM
MaxSem closed subtask T206293: Kartographer tests are failing on PHP 7.1 as Resolved.Oct 9 2018, 11:02 PM
Legoktm closed subtask T206100: Wikibase\Lexeme\Tests\MediaWiki\Search\LexemeCompletionSearchTest fails on PHP 7.1 as Resolved.Oct 10 2018, 5:34 PM
Legoktm closed subtask T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1 as Resolved.
gerritbot added a comment.Oct 11 2018, 11:24 PM

Change 466811 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[integration/config@master] Make MediaWiki PHP 7.1 tests voting

https://gerrit.wikimedia.org/r/466811

gerritbot added a comment.Oct 12 2018, 3:52 AM

Change 466811 merged by jenkins-bot:
[integration/config@master] Make MediaWiki PHP 7.1 tests voting

https://gerrit.wikimedia.org/r/466811

Legoktm reopened subtask T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1 as Open.Oct 12 2018, 4:31 AM
Smalyshev closed subtask T205958: Wikibase\Repo\Search\Elastic\Tests\EntitySearchElasticFulltextTest::testSearchElastic fails on PHP 7.1 as Resolved.Oct 12 2018, 8:46 PM
gerritbot added a comment.Oct 12 2018, 9:32 PM

Change 466991 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[integration/config@master] Add quibble-stretch-php72 image

https://gerrit.wikimedia.org/r/466991

gerritbot added a comment.Oct 13 2018, 1:54 AM

Change 466991 merged by jenkins-bot:
[integration/config@master] Add quibble-stretch-php72 image

https://gerrit.wikimedia.org/r/466991

Legoktm added a subtask: T206541: EchoUserNotificationGatewayTest::testMarkAllRead fails count(): Parameter must be an array or an object that implements Countable.Oct 13 2018, 3:40 AM
Legoktm added a subtask: T206899: CirrusSearch\Test\RequestLoggerTest::testRequestLogging fails on PHP 7.2 due to each().Oct 13 2018, 3:42 AM
Legoktm added a subtask: T206900: CollaborationHubContentTest::testGetMembersBlock fails on PHP 7.2.Oct 13 2018, 3:58 AM
Legoktm added a subtask: T196412: Fix "PHP Warning: count(): Parameter must be an array or Countable" in FlaggedRevs/backend/FRUserActivity.php.Oct 13 2018, 5:00 AM
Legoktm closed subtask T206541: EchoUserNotificationGatewayTest::testMarkAllRead fails count(): Parameter must be an array or an object that implements Countable as Resolved.Oct 13 2018, 5:03 AM
Legoktm added a subtask: T206901: MediaWiki\MassMessage\MassMessageJobTest::testLQTMessageSending fails in PHP 7.2.Oct 13 2018, 6:12 AM
gerritbot added a comment.Oct 13 2018, 6:48 AM

Change 467026 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] travis: Remove PHP 7.2 from allowed failures

https://gerrit.wikimedia.org/r/467026

gerritbot added a comment.Oct 13 2018, 7:17 AM

Change 467026 merged by jenkins-bot:
[mediawiki/core@master] travis: Remove PHP 7.2 from allowed failures

https://gerrit.wikimedia.org/r/467026

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 13 2018, 8:00 AM
Legoktm added a subtask: T206583: Flow\Tests\Import\TalkpageImportOperationTest::testImportDoesntCompletelyFail fails on PHP 7.2.Oct 13 2018, 5:04 PM
Krinkle closed subtask T196412: Fix "PHP Warning: count(): Parameter must be an array or Countable" in FlaggedRevs/backend/FRUserActivity.php as Resolved.Oct 14 2018, 3:03 AM
CCicalese_WMF edited projects, added Platform Team Workboards (Doing); removed Platform Team Legacy (Designing).Oct 14 2018, 3:58 PM
Jdforrester-WMF added a subtask: T202087: TemplateData emits count() parameter warning on PHP7.2.Oct 15 2018, 5:19 PM
Jdforrester-WMF closed subtask T202087: TemplateData emits count() parameter warning on PHP7.2 as Resolved.
Jdforrester-WMF closed subtask T206901: MediaWiki\MassMessage\MassMessageJobTest::testLQTMessageSending fails in PHP 7.2 as Resolved.Oct 15 2018, 5:41 PM
Legoktm renamed this task from Run MediaWiki tests on PHP 7.2 to Run MediaWiki tests on PHP 7.3.Oct 15 2018, 9:52 PM
Legoktm updated the task description. (Show Details)
gerritbot added a comment.Oct 15 2018, 9:55 PM

Change 467259 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[integration/config@master] Add Quibble PHP 7.3 image

https://gerrit.wikimedia.org/r/467259

gerritbot added a comment.Oct 15 2018, 9:57 PM

Change 467259 merged by jenkins-bot:
[integration/config@master] Add Quibble PHP 7.3 image

https://gerrit.wikimedia.org/r/467259

gerritbot added a comment.Oct 15 2018, 10:14 PM

Change 467536 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[integration/config@master] Add experimental Quibble PHP 7.3 jobs

https://gerrit.wikimedia.org/r/467536

gerritbot added a comment.Oct 15 2018, 10:25 PM

Change 467536 merged by jenkins-bot:
[integration/config@master] Add experimental Quibble PHP 7.3 jobs

https://gerrit.wikimedia.org/r/467536

Legoktm added a subtask: T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3.Oct 15 2018, 10:45 PM
Legoktm added a subtask: T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3.Oct 16 2018, 2:55 AM
Legoktm added a project: PHP 7.3 support.
Legoktm closed subtask T206899: CirrusSearch\Test\RequestLoggerTest::testRequestLogging fails on PHP 7.2 due to each() as Resolved.Oct 16 2018, 6:05 AM
Legoktm added a subtask: T207112: session_id(): Cannot change session id when session is active test failures on PHP 7.3.Oct 16 2018, 6:07 AM
Liuxinyu970226 subscribed.Oct 16 2018, 1:22 PM
Legoktm closed subtask T207112: session_id(): Cannot change session id when session is active test failures on PHP 7.3 as Resolved.Oct 16 2018, 4:12 PM
RazeSoldier subscribed.Oct 17 2018, 3:12 AM

Are we planning to add PHP 7.3 to our travis CI?

Legoktm added a comment.Oct 17 2018, 4:05 AM
In T204884#4673093, @RazeSoldier wrote:

Are we planning to add PHP 7.3 to our travis CI?

Yeah, we should do that eventually. But I don't think it'll add any extra value over what we have Jenkins doing right now.

Legoktm closed subtask T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3 as Resolved.Oct 17 2018, 5:25 AM
RazeSoldier reopened subtask T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3 as Open.Oct 17 2018, 5:22 PM
Reedy removed a project: PHP 7.2 support.Oct 20 2018, 6:31 PM
kostajh subscribed.Oct 29 2018, 8:45 PM
Lens0021 subscribed.Oct 31 2018, 5:09 AM
Etonkovidova closed subtask T206583: Flow\Tests\Import\TalkpageImportOperationTest::testImportDoesntCompletelyFail fails on PHP 7.2 as Resolved.Nov 5 2018, 5:21 PM
kostajh closed subtask T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3 as Resolved.Nov 7 2018, 7:42 PM
Liuxinyu970226 unsubscribed.Nov 8 2018, 4:18 AM
Legoktm closed subtask T206900: CollaborationHubContentTest::testGetMembersBlock fails on PHP 7.2 as Resolved.Nov 10 2018, 2:40 AM
gerritbot added a comment.Nov 14 2018, 12:52 AM

Change 473312 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[integration/config@master] Make PHP 7.2 MediaWiki tests voting

https://gerrit.wikimedia.org/r/473312

gerritbot added a comment.Nov 14 2018, 12:59 AM

Change 473312 merged by jenkins-bot:
[integration/config@master] Make PHP 7.2 MediaWiki tests voting

https://gerrit.wikimedia.org/r/473312

Krinkle moved this task from Backlog to MediaWiki core on the PHP 7.3 support board.Dec 9 2018, 6:47 PM
Legoktm closed subtask T209756: IPSet tests fail on PHP 7.3 as Resolved.Dec 18 2018, 8:05 AM
hashar moved this task from Untriaged to In-progress on the Continuous-Integration-Infrastructure board.Jan 1 2019, 5:31 PM
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 3:52 PM
Krinkle added a project: MW-1.34-release.Jun 8 2019, 8:57 PM
WDoranWMF removed Legoktm as the assignee of this task.Jul 5 2019, 6:26 PM
WDoranWMF removed a project: Platform Team Workboards (Doing).
tstarling closed subtask T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3 as Resolved.Jul 24 2019, 5:06 AM
Reedy subscribed.Jul 24 2019, 6:55 AM

Time to move 73 from experimental?

gerritbot added a comment.Jul 24 2019, 6:56 AM

Change 525214 had a related patch set uploaded (by Reedy; owner: Reedy):
[integration/config@master] Move PHP 7.3 jobs from experimental

https://gerrit.wikimedia.org/r/525214

gerritbot added a project: Patch-For-Review.Jul 24 2019, 6:56 AM
gerritbot added a comment.Jul 24 2019, 2:40 PM

Change 525296 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] .travis.yml: Don't allow failures for PHP 7.3 any more

https://gerrit.wikimedia.org/r/525296

gerritbot added a comment.Jul 24 2019, 2:54 PM

Change 525296 merged by jenkins-bot:
[mediawiki/core@master] .travis.yml: Don't allow failures for PHP 7.3 any more

https://gerrit.wikimedia.org/r/525296

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 24 2019, 3:00 PM
gerritbot added a comment.Jul 24 2019, 3:49 PM

Change 525214 merged by jenkins-bot:
[integration/config@master] layout: [quibble] Move all PHP 7.3 jobs from experimental to voting

https://gerrit.wikimedia.org/r/525214

Jdforrester-WMF subscribed.Jul 24 2019, 3:53 PM

This is now live.

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2019, 4:10 PM
Jdforrester-WMF closed this task as Resolved.Jul 24 2019, 4:15 PM
Jdforrester-WMF assigned this task to Reedy.
Jdforrester-WMF added a project: Release-Engineering-Team-TODO (201907).
Jdforrester-WMF moved this task from INBOX to Completed on the Release-Engineering-Team-TODO (201907) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL