Page MenuHomePhabricator
Create Task
Maniphest T207100

LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3
Closed, ResolvedPublic
Actions

Description

15:39:38 1) LanguageTrTest::testDottedAndDotlessI with data set #3 ('lcfirst', 'İ', 'upper', 'i')
15:39:38 Converting upper case 'İ' with lcfirst should give 'i'
15:39:38 Failed asserting that two strings are equal.
15:39:38 --- Expected
15:39:38 +++ Actual
15:39:38 @@ @@
15:39:38 -'i'
15:39:38 +'i̇'
15:39:38 
15:39:38 /workspace/src/tests/phpunit/languages/classes/LanguageTrTest.php:35
15:39:38 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
15:39:38 /workspace/src/maintenance/doMaintenance.php:94

(Those are not the same i.)

https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php73-docker/1/console

Details

SubjectRepoBranchLines +/-
Update LanguageTrTest for PHP 7.3 mbstring changesmediawiki/coremaster+3 -1
Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3mediawiki/coreREL1_33+21 -6
Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3mediawiki/coreREL1_32+21 -6
Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3mediawiki/coreREL1_31+21 -6
Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3mediawiki/coremaster+20 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Oct 15 2018, 10:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 15 2018, 10:44 PM
Legoktm added a parent task: T204884: Run MediaWiki tests on PHP 7.3.Oct 15 2018, 10:45 PM
Legoktm moved this task from Backlog to MediaWiki core on the PHP 7.3 support board.Oct 16 2018, 2:56 AM
Legoktm added subscribers: matmarex, Anomie.Oct 16 2018, 6:21 AM

I wonder if this is caused by some of the mbstring changes? https://github.com/php/php-src/blob/php-7.3.0RC3/UPGRADING#L186

Anomie added a comment.Oct 16 2018, 1:33 PM

The first is U+0069, the normal "i". The second is two characters, U+0069 U+0307, which is the normal "i" plus the combining dot above "◌̇".

It probably is due to the mbstring changes, in particular the "full case-mapping [which] may change the length of the string".

gerritbot subscribed.Oct 16 2018, 4:20 PM

Change 467727 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] Update LanguageTrTest for PHP 7.3 mbstring changes

https://gerrit.wikimedia.org/r/467727

gerritbot added a project: Patch-For-Review.Oct 16 2018, 4:20 PM
Legoktm added a project: Platform Engineering (PHP7 (TEC4)).Oct 16 2018, 4:29 PM
CCicalese_WMF added a project: Platform Team Workboards (Doing).Oct 16 2018, 7:13 PM
CCicalese_WMF assigned this task to Legoktm.Nov 27 2018, 2:12 AM
RazeSoldier added a parent task: T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.Dec 18 2018, 12:28 AM
RazeSoldier mentioned this in T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.Dec 18 2018, 12:31 AM
Krinkle added a project: MW-1.34-release.Jun 8 2019, 8:56 PM
Anomie mentioned this in T225244: Travis CI failures in ApiQueryLanguageinfoTest.Jun 12 2019, 2:41 PM
Reedy added subscribers: CCicalese_WMF, Reedy.Jun 13 2019, 7:18 PM

I'm not sure if Lego has any time to work on this based on no activity since November... Can anyone else from CPT pick this up @CCicalese_WMF as the last (known) blocker for PHP 7.3 support?

It doesn't sound like a lot of work is needed to finish it off

Legoktm removed Legoktm as the assignee of this task.Jun 13 2019, 7:18 PM

Sorry for cookie licking, I haven't worked on this since October :(

Reedy added a project: Language-Team.Jun 13 2019, 7:21 PM

Or maybe Language-Team might be interested?

CCicalese_WMF edited projects, added Platform Team Workboards (Team 3); removed Platform Team Workboards (Doing).Jun 14 2019, 1:48 PM

We'll see if we can fit this in to an upcoming sprint.

CCicalese_WMF edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Team Workboards (Team 3).Jul 9 2019, 8:08 PM
WDoranWMF triaged this task as Low priority.Jul 17 2019, 8:25 PM
WDoranWMF moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.
tstarling subscribed.Jul 23 2019, 12:02 AM

Prior to PHP 7.3, the mbstring case tables were derived from UnicodeData.txt, which has U+0130 -> U+0069 as a case mapping. In 7.3+, CaseFolding.txt is used instead, which terms this mapping a special-case Turkic mapping, for language codes tr and az only. PHP 7.3's data parser thus ignores this mapping, preferring the "non-Turkic" F-type mapping U+0130 -> U+0069 U+0307. So the correct thing to do here is to implement this special mapping in LanguageTr::ucfirst().

We may also want to review the other case-folding changes in PHP 7.3, but for this task, it's a simple fix.

gerritbot added a comment.Jul 23 2019, 6:58 AM

Change 525032 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/core@master] Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3

https://gerrit.wikimedia.org/r/525032

• santhosh claimed this task.Jul 23 2019, 7:00 AM
• santhosh subscribed.

So the correct thing to do here is to implement this special mapping in LanguageTr::ucfirst().

As @tstarling suggested, I implemented the 'T' type mapping to the LanguageTr in https://gerrit.wikimedia.org/r/525032

gerritbot added a comment.Jul 23 2019, 11:01 AM

Change 525032 merged by jenkins-bot:
[mediawiki/core@master] Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3

https://gerrit.wikimedia.org/r/525032

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 23 2019, 12:00 PM
tstarling closed this task as Resolved.Jul 24 2019, 5:06 AM
gerritbot added a comment.Jul 24 2019, 5:28 AM

Change 525198 had a related patch set uploaded (by Reedy; owner: Santhosh):
[mediawiki/core@REL1_31] Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3

https://gerrit.wikimedia.org/r/525198

gerritbot added a comment.Jul 24 2019, 5:28 AM

Change 525199 had a related patch set uploaded (by Reedy; owner: Santhosh):
[mediawiki/core@REL1_32] Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3

https://gerrit.wikimedia.org/r/525199

gerritbot added a comment.Jul 24 2019, 5:28 AM

Change 525200 had a related patch set uploaded (by Reedy; owner: Santhosh):
[mediawiki/core@REL1_33] Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3

https://gerrit.wikimedia.org/r/525200

gerritbot added a comment.Jul 24 2019, 6:19 AM

Change 525198 merged by jenkins-bot:
[mediawiki/core@REL1_31] Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3

https://gerrit.wikimedia.org/r/525198

gerritbot added a comment.Jul 24 2019, 6:24 AM

Change 525199 merged by jenkins-bot:
[mediawiki/core@REL1_32] Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3

https://gerrit.wikimedia.org/r/525199

gerritbot added a comment.Jul 24 2019, 6:28 AM

Change 525200 merged by jenkins-bot:
[mediawiki/core@REL1_33] Update LanguageTrTest::testDottedAndDotlessI for PHP 7.3

https://gerrit.wikimedia.org/r/525200

Reedy removed a project: Patch-For-Review.Jul 24 2019, 6:46 AM
ReleaseTaggerBot added projects: MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes.Jul 24 2019, 7:00 AM
WDoranWMF moved this task from Later to Done on the Platform Team Workboards (Clinic Duty Team) board.Aug 1 2019, 7:45 PM
gerritbot added a comment.Jan 1 2020, 9:05 PM

Change 467727 abandoned by Legoktm:
Update LanguageTrTest for PHP 7.3 mbstring changes

Reason:
Already fixed

https://gerrit.wikimedia.org/r/467727

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL