Maniphest T190024

Elastica 5.3 uses the each keyword which is deprecated in PHP 7.2
Closed, ResolvedPublic
Actions

Description

It may cause a lot of deprecation warnings for users switching to PHP 7.2 as it is used in the Transport/Http class.
Should we try to upstream a patch to remove 7.2 deprecation warnings?
We could also try to see if we can use the Elastica extension itself to backport a fix there, Transport class can be extended IIRC.

Details

	Subject	Repo	Branch	Lines +/-
	ruflin/elastica: Backport patch to stop using each()	mediawiki/vendor	master	+5 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	EBernhardson	T183281 [epic] ELK upgrade to 6.x (elasticsearch, kibana, logstash)
Resolved	None	T183282 [epic] Search cluster upgrade to 6.x
Resolved	Reedy	T204884 Run MediaWiki tests on PHP 7.3
Resolved	Legoktm	T206899 CirrusSearch\Test\RequestLoggerTest::testRequestLogging fails on PHP 7.2 due to each()
Resolved	Legoktm	T190024 Elastica 5.3 uses the each keyword which is deprecated in PHP 7.2

Event Timeline

dcausse created this task.Mar 19 2018, 9:46 AM

Restricted Application added projects: Discovery-ARCHIVED, Discovery-Search. · View Herald TranscriptMar 19 2018, 9:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Reedy added a project: PHP 7.2 support.Mar 19 2018, 9:49 AM

RazeSoldier moved this task from Untriaged to Other on the PHP 7.2 support board.Mar 23 2018, 4:29 AM

I'm certain upstream has already fixed this, just not in the versions we support. Elastica 6 supports php 7, but also requires elasticsearch 6. We could do some custom hacks locally until we are ready for 6?

I'm certain upstream has already fixed this

Indeed: https://github.com/ruflin/Elastica/commit/4112024cb273e9f09d691b670f5de334a41db721

• EBjune added a parent task: T183282: [epic] Search cluster upgrade to 6.x.May 10 2018, 5:30 PM

• EBjune triaged this task as Medium priority.Jun 7 2018, 5:17 PM

• EBjune moved this task from needs triage to watching / waiting on the Discovery-Search board.

Legoktm moved this task from Other to Wikimedia production on the PHP 7.2 support board.Aug 2 2018, 2:53 AM

Change 467079 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/vendor@master] ruflin/elastica: Backport patch to stop using each()

https://gerrit.wikimedia.org/r/467079

gerritbot added a project: Patch-For-Review.Oct 13 2018, 4:41 PM

Legoktm added a parent task: T206899: CirrusSearch\Test\RequestLoggerTest::testRequestLogging fails on PHP 7.2 due to each().Oct 13 2018, 4:42 PM

Change 467079 merged by jenkins-bot:
[mediawiki/vendor@master] ruflin/elastica: Backport patch to stop using each()

https://gerrit.wikimedia.org/r/467079

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 15 2018, 10:01 PM