Page MenuHomePhabricator

Popups tests are failing on PHP 7.1
Closed, ResolvedPublic

Description

122:43:34 There were 16 errors:
222:43:34
322:43:34 1) PopupsContextTest::testShowPreviewsPreferencesPage with data set #0 (array(false), true)
422:43:34 A non-numeric value encountered
522:43:34
622:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:72
722:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
822:43:34 /workspace/src/maintenance/doMaintenance.php:94
922:43:34
1022:43:34 2) PopupsContextTest::testShowPreviewsPreferencesPage with data set #1 (array(true), false)
1122:43:34 A non-numeric value encountered
1222:43:34
1322:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:72
1422:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
1522:43:34 /workspace/src/maintenance/doMaintenance.php:94
1622:43:34
1722:43:34 3) PopupsContextTest::testShouldSendModuleToUser with data set #0 ('1', true)
1822:43:34 A non-numeric value encountered
1922:43:34
2022:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:107
2122:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
2222:43:34 /workspace/src/maintenance/doMaintenance.php:94
2322:43:34
2422:43:34 4) PopupsContextTest::testShouldSendModuleToUser with data set #1 ('0', false)
2522:43:34 A non-numeric value encountered
2622:43:34
2722:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:107
2822:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
2922:43:34 /workspace/src/maintenance/doMaintenance.php:94
3022:43:34
3122:43:34 5) PopupsContextTest::testAnonUserHasDisabledPagePreviews with data set #0 (true)
3222:43:34 A non-numeric value encountered
3322:43:34
3422:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:140
3522:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
3622:43:34 /workspace/src/maintenance/doMaintenance.php:94
3722:43:34
3822:43:34 6) PopupsContextTest::testAreDependenciesMet with data set #0 (true, true, 'mwApiPlain', true)
3922:43:34 A non-numeric value encountered
4022:43:34
4122:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:171
4222:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
4322:43:34 /workspace/src/maintenance/doMaintenance.php:94
4422:43:34
4522:43:34 7) PopupsContextTest::testAreDependenciesMet with data set #1 (false, true, 'mwApiPlain', false)
4622:43:34 A non-numeric value encountered
4722:43:34
4822:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:171
4922:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
5022:43:34 /workspace/src/maintenance/doMaintenance.php:94
5122:43:34
5222:43:34 8) PopupsContextTest::testAreDependenciesMet with data set #2 (true, false, 'mwApiPlain', false)
5322:43:34 A non-numeric value encountered
5422:43:34
5522:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:171
5622:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
5722:43:34 /workspace/src/maintenance/doMaintenance.php:94
5822:43:34
5922:43:34 9) PopupsContextTest::testAreDependenciesMet with data set #3 (false, false, 'restbaseHTML', true)
6022:43:34 A non-numeric value encountered
6122:43:34
6222:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:171
6322:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
6422:43:34 /workspace/src/maintenance/doMaintenance.php:94
6522:43:34
6622:43:34 10) PopupsContextTest::testIsTitleBlacklisted with data set #0 (array('Special:Userlogin', 'Special:CreateAccount', 'User:A'), Title Object (...), false)
6722:43:34 A non-numeric value encountered
6822:43:34
6922:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:222
7022:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
7122:43:34 /workspace/src/maintenance/doMaintenance.php:94
7222:43:34
7322:43:34 11) PopupsContextTest::testIsTitleBlacklisted with data set #1 (array('Special:Userlogin', 'Special:CreateAccount', 'User:A'), Title Object (...), true)
7422:43:34 A non-numeric value encountered
7522:43:34
7622:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:222
7722:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
7822:43:34 /workspace/src/maintenance/doMaintenance.php:94
7922:43:34
8022:43:34 12) PopupsContextTest::testIsTitleBlacklisted with data set #2 (array('Special:Userlogin', 'Special:CreateAccount', 'User:A'), Title Object (...), true)
8122:43:34 A non-numeric value encountered
8222:43:34
8322:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:222
8422:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
8522:43:34 /workspace/src/maintenance/doMaintenance.php:94
8622:43:34
8722:43:34 13) PopupsContextTest::testIsTitleBlacklisted with data set #3 (array('Special:Userlogin', 'Special:CreateAccount', 'User:A'), Title Object (...), true)
8822:43:34 A non-numeric value encountered
8922:43:34
9022:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:222
9122:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
9222:43:34 /workspace/src/maintenance/doMaintenance.php:94
9322:43:34
9422:43:34 14) PopupsContextTest::testIsTitleBlacklisted with data set #4 (array('Special:Userlogin', 'Special:CreateAccount', 'User:A'), Title Object (...), false)
9522:43:34 A non-numeric value encountered
9622:43:34
9722:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:222
9822:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
9922:43:34 /workspace/src/maintenance/doMaintenance.php:94
10022:43:34
10122:43:34 15) PopupsContextTest::testIsTitleBlacklisted with data set #5 (array('Special:Userlogin', 'Special:CreateAccount', 'User:A'), Title Object (...), false)
10222:43:34 A non-numeric value encountered
10322:43:34
10422:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:222
10522:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
10622:43:34 /workspace/src/maintenance/doMaintenance.php:94
10722:43:34
10822:43:34 16) PopupsContextTest::testIsTitleBlacklisted with data set #6 (array('Special:Userlogin', 'Special:CreateAccount', 'User:A'), Title Object (...), true)
10922:43:34 A non-numeric value encountered
11022:43:34
11122:43:34 /workspace/src/extensions/Popups/tests/phpunit/PopupsContextTest.php:222
11222:43:34 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
11322:43:34 /workspace/src/maintenance/doMaintenance.php:94

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php71-docker/430/consoleFull

You can comment "check experimental" to trigger PHP 7.1 tests to verify the fix.

Event Timeline

Legoktm created this task.Oct 5 2018, 5:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 5 2018, 5:49 AM
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.
Jdlrobson added a subscriber: pmiazga.
Jdlrobson added a subscriber: Jdlrobson.
Jdlrobson triaged this task as Medium priority.Oct 5 2018, 4:25 PM

Change 464921 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Popups@master] PHP tests: Use the . not + operator to join strings

https://gerrit.wikimedia.org/r/464921

Legoktm closed this task as Resolved.Oct 6 2018, 5:50 AM
Legoktm assigned this task to Jdforrester-WMF.

Change 464921 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] PHP tests: Use the . not + operator to join strings

https://gerrit.wikimedia.org/r/464921