Maniphest T206541

EchoUserNotificationGatewayTest::testMarkAllRead fails count(): Parameter must be an array or an object that implements Countable
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Oct 9 2018, 3:05 PM

Description

Noticed by @D3r1ck01

20:32:15 1) EchoUserNotificationGatewayTest::testMarkRead
20:32:15 count(): Parameter must be an array or an object that implements Countable
20:32:15 
20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126
20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93
20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:10
20:32:15 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
20:32:15 /workspace/src/maintenance/doMaintenance.php:94
20:32:15 
20:32:15 2) EchoUserNotificationGatewayTest::testMarkAllRead
20:32:15 count(): Parameter must be an array or an object that implements Countable
20:32:15 
20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126
20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93
20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:24
20:32:15 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
20:32:15 /workspace/src/maintenance/doMaintenance.php:94
20:32:15 
20:32:15 3) EchoUserNotificationGatewayTest::testGetNotificationCount
20:32:15 count(): Parameter must be an array or an object that implements Countable
20:32:15 
20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126
20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93
20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:34
20:32:15 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
20:32:15 /workspace/src/maintenance/doMaintenance.php:94
20:32:15 
20:32:15 4) EchoUserNotificationGatewayTest::testGetUnreadNotifications
20:32:15 count(): Parameter must be an array or an object that implements Countable
20:32:15 
20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:126
20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:93
20:32:15 /workspace/src/extensions/Echo/tests/phpunit/gateway/UserNotificationGatewayTest.php:51
20:32:15 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
20:32:15 /workspace/src/maintenance/doMaintenance.php:94

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/22/consoleFull

Can be verified by commenting "check experimental" on a patch to trigger the PHP 7.2 job.

Details

	Subject	Repo	Branch	Lines +/-
	Don't call count() with a non-countable value	mediawiki/extensions/Echo	REL1_31	+2 -1
	Don't call count() with a non-countable value	mediawiki/extensions/Echo	master	+2 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Reedy	T204884 Run MediaWiki tests on PHP 7.3
		Resolved		Legoktm	T206541 EchoUserNotificationGatewayTest::testMarkAllRead fails count(): Parameter must be an array or an object that implements Countable

Event Timeline

Reedy created this task.Oct 9 2018, 3:05 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 9 2018, 3:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

xSavitar updated the task description. (Show Details)Oct 9 2018, 3:15 PM

Krinkle moved this task from Untriaged to Wikimedia production on the PHP 7.2 support board.Oct 12 2018, 6:47 PM

Legoktm renamed this task from Echo Countable Errors to EchoUserNotificationGatewayTest::testMarkAllRead fails count(): Parameter must be an array or an object that implements Countable.Oct 13 2018, 3:39 AM

Legoktm triaged this task as High priority.

Legoktm updated the task description. (Show Details)

Legoktm added a parent task: T204884: Run MediaWiki tests on PHP 7.3.

Change 467021 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Echo@master] Don't call count() with a non-countable value

https://gerrit.wikimedia.org/r/467021

gerritbot added a project: Patch-For-Review.Oct 13 2018, 3:50 AM

Change 467021 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Don't call count() with a non-countable value

https://gerrit.wikimedia.org/r/467021

Legoktm closed this task as Resolved.Oct 13 2018, 5:03 AM

Legoktm claimed this task.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 13 2018, 6:00 AM

Change 481503 had a related patch set uploaded (by Paladox; owner: Legoktm):
[mediawiki/extensions/Echo@REL1_31] Don't call count() with a non-countable value

https://gerrit.wikimedia.org/r/481503

Change 481503 merged by jenkins-bot:
[mediawiki/extensions/Echo@REL1_31] Don't call count() with a non-countable value