Maniphest T206286

FileImporter tests are failing on PHP 7.1
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

19:59:51 1) FileImporter\Remote\MediaWiki\Test\ApiDetailRetrieverTest::testValidResponse with data set #0 (FileImporter\Data\SourceUrl Object (...), 'File:Foo.png', '{"query":{"pages":[{"title":"...}]}]}}', array('Foo.png', 'Foo', 'png'))
19:59:51 A non-numeric value encountered
19:59:51 
19:59:51 /workspace/src/extensions/FileImporter/src/Remote/MediaWiki/ApiDetailRetriever.php:402
19:59:51 /workspace/src/extensions/FileImporter/src/Remote/MediaWiki/ApiDetailRetriever.php:225
19:59:51 /workspace/src/extensions/FileImporter/tests/phpunit/Remote/MediaWiki/ApiDetailRetrieverTest.php:431
19:59:51 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
19:59:51 /workspace/src/maintenance/doMaintenance.php:94
19:59:51 
19:59:51 2) FileImporter\Remote\MediaWiki\Test\ApiDetailRetrieverTest::testValidResponse with data set #1 (FileImporter\Data\SourceUrl Object (...), 'Datei:Bar+1.JPG', '{"query":{"pages":[{"title":"...}]}]}}', array('Bar+1.JPG', 'Bar+1', 'JPG'))
19:59:51 A non-numeric value encountered
19:59:51 
19:59:51 /workspace/src/extensions/FileImporter/src/Remote/MediaWiki/ApiDetailRetriever.php:402
19:59:51 /workspace/src/extensions/FileImporter/src/Remote/MediaWiki/ApiDetailRetriever.php:225
19:59:51 /workspace/src/extensions/FileImporter/tests/phpunit/Remote/MediaWiki/ApiDetailRetrieverTest.php:431
19:59:51 /workspace/src/tests/phpunit/MediaWikiTestCase.php:416
19:59:51 /workspace/src/maintenance/doMaintenance.php:94

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php71-docker/166/consoleFull

You can comment "check experimental" to trigger PHP 7.1 tests to verify the fix.

Details

	Subject	Repo	Branch	Lines +/-
	Fix non-numeric value in ApiDetailRetrieverTest	mediawiki/extensions/FileImporter	REL1_31	+1 -1
	Fix non-numeric value in ApiDetailRetrieverTest	mediawiki/extensions/FileImporter	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Reedy	T204884 Run MediaWiki tests on PHP 7.3
		Resolved		thiemowmde	T206286 FileImporter tests are failing on PHP 7.1

Event Timeline

Legoktm created this task.Oct 5 2018, 4:22 AM

Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptOct 5 2018, 4:22 AM

Legoktm added a parent task: T204884: Run MediaWiki tests on PHP 7.3.Oct 5 2018, 5:14 AM

Legoktm moved this task from Backlog to Wikimedia production on the PHP 7.1 support board.Oct 5 2018, 5:20 AM

Change 465124 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@master] Fix non-numeric value in ApiDetailRetrieverTest

https://gerrit.wikimedia.org/r/465124

gerritbot added a project: Patch-For-Review.Oct 8 2018, 7:53 AM

thiemowmde claimed this task.Oct 8 2018, 7:54 AM

thiemowmde triaged this task as Medium priority.

thiemowmde moved this task from Incoming to Move files to Commons on the TCB-Team (now WMDE-TechWish) board.

thiemowmde added subscribers: thiemowmde, WMDE-Fisch, • Lea_WMDE.

thiemowmde mentioned this in rEFLI5aff8e51149e: Fix non-numeric value in ApiDetailRetrieverTest.Oct 8 2018, 8:22 AM

Change 465124 merged by jenkins-bot:
[mediawiki/extensions/FileImporter@master] Fix non-numeric value in ApiDetailRetrieverTest

https://gerrit.wikimedia.org/r/465124

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 8 2018, 9:00 AM

@thiemowmde could you add this to the sprint including a rough guess on the points you invested? ;-)

thiemowmde closed this task as Resolved.Oct 8 2018, 9:20 AM

thiemowmde added a project: WMDE-QWERTY-Sprint-2018-09-25.

thiemowmde set the point value for this task to 2.

thiemowmde moved this task from Sprint Backlog to Done on the WMDE-QWERTY-Sprint-2018-09-25 board.

Change 652941 had a related patch set uploaded (by Umherirrender; owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/FileImporter@REL1_31] Fix non-numeric value in ApiDetailRetrieverTest

https://gerrit.wikimedia.org/r/652941

Change 652941 merged by Umherirrender:
[mediawiki/extensions/FileImporter@REL1_31] Fix non-numeric value in ApiDetailRetrieverTest

https://gerrit.wikimedia.org/r/652941

Umherirrender mentioned this in rEFLI375fc6832394: Fix non-numeric value in ApiDetailRetrieverTest.Jan 1 2021, 12:48 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 1 2021, 1:10 PM

thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:58 PM