Page MenuHomePhabricator

No acknowledgement when suppressing AbuseFilter entries
Open, Needs TriagePublic

Description

When a sysop revision deletes one or more revision(s) or log(s), they are returned to that same Special:RevisionDelete page with the log of their action(s) and a green message indicating success.

When (un)suppressing an AbuseFilter entry, however, an oversighter are returned to the entire generic Special:AbuseLog with no feedback or acknowledgement to the user that the entry was successfully (un)suppressed; the oversighter must use the back button in their browser to confirm success.

Details

Related Gerrit Patches:
mediawiki/extensions/AbuseFilter : masterOverhaul the interface for hiding AbuseLog entries

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2018, 1:57 AM

While this may be relatively easy, I'd rather wait for T144096, so that if the suppression system is changed there, we can use that new system here.

Change 467774 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Overhaul the interface for hiding AbuseLog entries

https://gerrit.wikimedia.org/r/467774

Daimona claimed this task.Oct 16 2018, 8:01 PM

@Daimona Not to further complicate your work on this, but one thing that is nice about the bulk revision delete system on history pages is that, if an item is already hidden and is then attempted to be hidden as part of a bulk revdel action, the page reports the error on that item but makes the change on all the remaining revisions just fine. Would this have a similar behavior? I'm likewise thinking of T144096 and avoiding creating duplicate entries vis a vis T206945 or T206938.

@Amorymeltzer I just tested it to be sure, the behaviour is that the already-hidden entry is left as it is, no errors arise, but other entries are correctly suppressed. I'd also like to note that this patch changes the way suppressed items show up: instead of the message at the end of the line, the whole line is greyed and striked (like for revisions), so it's easier to notice which entries are/aren't hidden.

Change 467774 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Overhaul the interface for hiding AbuseLog entries

https://gerrit.wikimedia.org/r/467774