Review the code and add test coverage where possible. Current statement coverage is attached.
| Total | 124/135 | 91.85% |
|---|---|---|
| LinearEscape | 14/16 | 87.50% |
| LinearTab | 26/29 | 89.66% |
| TableArrow | 56/58 | 96.55% |
| TableDelete | 16/17 | 94.12% |
| TableEnter | 12/15 | 80.00% |
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • marcella | T206138 [EPIC] Increase test coverage for VE.ce code | |||
| Resolved | • Esanders | T207080 Increase unit test coverage in ve/ce/KeyDownHandlers : LinearEscape, LinearTab, TableArrow, TableDelete, TableEnter |
Event Timeline
Comment Actions
Change 468719 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] KeyDownTests: Remove unused constructor calls for all static classes
Comment Actions
Change 468720 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] KeyDown tests: Add test for missing cases in TableEnter/LinearEscape
Comment Actions
Change 468719 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] KeyDownTests: Remove unused constructor calls for all static classes
Comment Actions
Change 468720 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] KeyDown tests: Add tests for missing cases to cover tab/escape/enter
Comment Actions
Change 469038 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (b2ece1abc)
Comment Actions
Change 469038 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6c288b44f)
Comment Actions
Now all at 100% statements, but two missed conditional branches of four for TableDeleteKeyDownHandler. Good enough?
Comment Actions
Can we add a screenshot here of the new test coverage, so that it can be compared to the old test coverage image in the description? I don't know where the test coverage dashboard shown here lives, so I can't do that myself.
