Maniphest T207652

JavaScript protection error message on some non-JavaScript MediaWiki messages
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	IKhitron
	Oct 22 2018, 11:59 AM

Description

Hi. There is a JavaScript protection on non JavaScript pages.

Open a wiki you have no editprotected rights on it.
Open, for example, MediaWiki:Wikimedia-copyright for source edting ("View source").
See the unexpected text "You do not have permission to edit this JavaScript page because it may affect all visitors".

Checked on a coouple of wikis to be sure it isn't a local bug.
Seems it should be removed. Thank you.

Details

	Subject	Repo	Branch	Lines +/-
	New error message for editing site pages with raw HTML	mediawiki/core	master	+18 -8

Customize query in gerrit

Related Objects

Mentioned Here: T45646: "MediaWiki:Copyright" message allows raw HTML

Event Timeline

IKhitron created this task.Oct 22 2018, 11:59 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2018, 11:59 AM

This is intended, see the patch where it was introduced, and also the reasoning behind it in T45646. However, I do recognize that reusing the messages isn't that clear, so we should probably add separate messages to handle this specific case. CC'ing @Tgr who wrote the patch.

Thank you. I also thought this can be the reason, but it's too confusing, indeed. New message is a good idea.

Schnark merged a task: T224266: MediaWiki:Wikimedia-copyright asks for sitewide CSS/JS/JSON.May 24 2019, 9:24 AM

Schnark added a subscriber: geraki.

Aklapper renamed this task from JavaScript protection on some MediaWiki messages to JavaScript protection error message on some non-JavaScript MediaWiki messages.May 24 2019, 9:30 AM

Maybe have it say "Javascript or HTML page"?

Change 551350 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] New error message for editing site pages with raw HTML

https://gerrit.wikimedia.org/r/551350

gerritbot added a project: Patch-For-Review.Nov 17 2019, 10:35 PM

Ammarpad claimed this task.Nov 17 2019, 10:42 PM

Ammarpad removed a project: JavaScript.Nov 17 2019, 10:44 PM

Change 551350 merged by jenkins-bot:
[mediawiki/core@master] New error message for editing site pages with raw HTML

https://gerrit.wikimedia.org/r/551350

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.8; 2019-11-26).Nov 23 2019, 6:00 PM

Ammarpad closed this task as Resolved.Nov 23 2019, 7:17 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 26 2019, 11:47 AM