Page MenuHomePhabricator

JavaScript protection error message on some non-JavaScript MediaWiki messages
Closed, ResolvedPublic

Description

Hi. There is a JavaScript protection on non JavaScript pages.

  1. Open a wiki you have no editprotected rights on it.
  2. Open, for example, MediaWiki:Wikimedia-copyright for source edting ("View source").
  3. See the unexpected text "You do not have permission to edit this JavaScript page because it may affect all visitors".

Checked on a coouple of wikis to be sure it isn't a local bug.
Seems it should be removed. Thank you.

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 22 2018, 11:59 AM

This is intended, see the patch where it was introduced, and also the reasoning behind it in T45646. However, I do recognize that reusing the messages isn't that clear, so we should probably add separate messages to handle this specific case. CC'ing @Tgr who wrote the patch.

Thank you. I also thought this can be the reason, but it's too confusing, indeed. New message is a good idea.

Aklapper renamed this task from JavaScript protection on some MediaWiki messages to JavaScript protection error message on some non-JavaScript MediaWiki messages.May 24 2019, 9:30 AM
Tgr added a comment.May 24 2019, 11:20 AM

Maybe have it say "Javascript or HTML page"?

Change 551350 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] New error message for editing site pages with raw HTML

https://gerrit.wikimedia.org/r/551350

Change 551350 merged by jenkins-bot:
[mediawiki/core@master] New error message for editing site pages with raw HTML

https://gerrit.wikimedia.org/r/551350

Ammarpad closed this task as Resolved.Sat, Nov 23, 7:17 PM