Page MenuHomePhabricator

ReadingDepth events should only be sent for pageviews
Closed, DeclinedPublic3 Estimated Story Points

Description

Background

(Per a discussion yesterday with @Jdlrobson and @Groceryheist:)

The ReadingDepth schema should not send events for user actions that are not considered page views - in particular, edits and action pages like action=history URLs should be excluded.

Special pages (namespace -1) can be left as is. (There is some value in having data for them too, which outweighs consistency with the pageview definition in this case - the pageview definition FAQ about this is a bit ambiguous and not entirely correct anyway.)

Developer notes

Currently ReadingDepth does not check the value of wgAction meaning ReadingDepth events are sent on https://en.wikipedia.org/wiki/Spain?action=edit, https://en.wikipedia.org/wiki/Spain?action=history etc..

A conditional should be added to prohibit this.

QA steps

ReadingDepth is enabled for 100% of users on Reading web staging

Event Timeline

On second thought, the data for some special pages might be valuable from a product perspective too, which may outweigh the value of consistency with the pageview definition (even more so as the latter is currently not clearly documented on the linked page). Will discuss with @ovasileva today.

ovasileva triaged this task as Medium priority.Nov 5 2018, 7:50 PM

On second thought, the data for some special pages might be valuable from a product perspective too, which may outweigh the value of consistency with the pageview definition (even more so as the latter is currently not clearly documented on the linked page). Will discuss with @ovasileva today.

Updated per discussion with @ovasileva