Page MenuHomePhabricator
Create Task
Maniphest T208106

Some EntityData urls abort with IllegalValueException: Value must be at most 127 characters long
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: W9OKGwpAICsAACqE6AkAAABK

Reproduction: http://wikidata.org/wiki/Special:EntityData/Q876237.ttl?nocache=1540590107881&flavor=dump

message
DataValues\IllegalValueException: Value must be at most 127 characters long.
trace
#0 /srv/mediawiki/php-1.33.0-wmf.1/vendor/data-values/number/src/DataValues/DecimalMath.php(68): DataValues\DecimalValue->__construct(string)
#1 [internal function]: DataValues\DecimalMath->product(DataValues\DecimalValue, DataValues\DecimalValue)
#2 /srv/mediawiki/php-1.33.0-wmf.1/vendor/data-values/number/src/DataValues/UnboundedQuantityValue.php(226): call_user_func_array(array, array)
#3 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/lib/includes/Units/UnitConverter.php(88): DataValues\UnboundedQuantityValue->transform(string, array, DataValues\DecimalValue)
#4 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Rdf/Values/QuantityRdfBuilder.php(76): Wikibase\Lib\Units\UnitConverter->toStandardUnits(DataValues\UnboundedQuantityValue)
#5 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Rdf/DispatchingValueSnakRdfBuilder.php(53): Wikibase\Rdf\Values\QuantityRdfBuilder->addValue(Wikimedia\Purtle\TurtleRdfWriter, string, string, string, Wikibase\DataModel\Snak\PropertyValueSnak)
#6 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Rdf/SnakRdfBuilder.php(132): Wikibase\Rdf\DispatchingValueSnakRdfBuilder->addValue(Wikimedia\Purtle\TurtleRdfWriter, string, string, string, Wikibase\DataModel\Snak\PropertyValueSnak)
#7 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Rdf/SnakRdfBuilder.php(83): Wikibase\Rdf\SnakRdfBuilder->addSnakValue(Wikimedia\Purtle\TurtleRdfWriter, Wikibase\DataModel\Snak\PropertyValueSnak, string)
#8 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Rdf/FullStatementRdfBuilder.php(228): Wikibase\Rdf\SnakRdfBuilder->addSnak(Wikimedia\Purtle\TurtleRdfWriter, Wikibase\DataModel\Snak\PropertyValueSnak, string)
#9 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Rdf/FullStatementRdfBuilder.php(140): Wikibase\Rdf\FullStatementRdfBuilder->addMainSnak(Wikibase\DataModel\Entity\ItemId, string, Wikibase\DataModel\Statement\Statement, boolean)
#10 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Rdf/FullStatementRdfBuilder.php(126): Wikibase\Rdf\FullStatementRdfBuilder->addStatement(Wikibase\DataModel\Entity\ItemId, Wikibase\DataModel\Statement\Statement, boolean)
#11 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Rdf/FullStatementRdfBuilder.php(242): Wikibase\Rdf\FullStatementRdfBuilder->addStatements(Wikibase\DataModel\Entity\ItemId, Wikibase\DataModel\Statement\StatementList)
#12 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Rdf/RdfBuilder.php(429): Wikibase\Rdf\FullStatementRdfBuilder->addEntity(Wikibase\DataModel\Entity\Item)
#13 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Rdf/RdfBuilder.php(410): Wikibase\Rdf\RdfBuilder->addSingleEntity(Wikibase\DataModel\Entity\Item)
#14 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(229): Wikibase\Rdf\RdfBuilder->addEntity(Wikibase\DataModel\Entity\Item)
#15 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(175): Wikibase\Repo\LinkedData\EntityDataSerializationService->rdfSerialize(Wikibase\Lib\Store\EntityRevision, NULL, array, Wikibase\Rdf\RdfBuilder, string)
#16 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(453): Wikibase\Repo\LinkedData\EntityDataSerializationService->getSerializedData(string, Wikibase\Lib\Store\EntityRevision, NULL, array, string)
#17 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(246): Wikibase\Repo\LinkedData\EntityDataRequestHandler->showData(WebRequest, OutputPage, string, Wikibase\DataModel\Entity\ItemId, integer)
#18 /srv/mediawiki/php-1.33.0-wmf.1/extensions/Wikibase/repo/includes/Specials/SpecialEntityData.php(153): Wikibase\Repo\LinkedData\EntityDataRequestHandler->handleRequest(string, WebRequest, OutputPage)
#19 /srv/mediawiki/php-1.33.0-wmf.1/includes/specialpage/SpecialPage.php(569): Wikibase\Repo\Specials\SpecialEntityData->execute(string)
#20 /srv/mediawiki/php-1.33.0-wmf.1/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(string)
#21 /srv/mediawiki/php-1.33.0-wmf.1/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#22 /srv/mediawiki/php-1.33.0-wmf.1/includes/MediaWiki.php(860): MediaWiki->performRequest()
#23 /srv/mediawiki/php-1.33.0-wmf.1/includes/MediaWiki.php(517): MediaWiki->main()
#24 /srv/mediawiki/php-1.33.0-wmf.1/index.php(42): MediaWiki->run()

Impact

Unknown.

Notes

Seen in the logs for at least 30 days (1.32-wmf.23).

See also T68636: Uncaught exception DataValues\IllegalValueException

Details

SubjectRepoBranchLines +/-
Require at least data-values/number 0.10.1mediawiki/extensions/Wikibasemaster+1 -1
Update data-values/number to 0.10.1mediawiki/vendormaster+41 -29
Customize query in gerrit

Related Objects

Event Timeline

Krinkle created this task.Oct 26 2018, 10:35 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptOct 26 2018, 10:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle moved this task from Untriaged to Older on the Wikimedia-production-error board.Oct 26 2018, 10:35 PM
Addshore updated the task description. (Show Details)Oct 27 2018, 8:03 AM
Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Oct 29 2018, 11:09 AM
hoo claimed this task.Oct 29 2018, 12:12 PM
hoo moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
hoo added a project: Patch-For-Review.Oct 29 2018, 12:24 PM
hoo moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Patch: https://github.com/DataValues/Number/pull/121

gerritbot subscribed.Oct 31 2018, 11:23 AM

Change 470809 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/vendor@master] Update data-values/number to 0.10.1

https://gerrit.wikimedia.org/r/470809

gerritbot added a comment.Oct 31 2018, 11:26 AM

Change 470810 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Require at least data-values/number 0.10.1

https://gerrit.wikimedia.org/r/470810

Addshore moved this task from incoming to in progress on the Wikidata board.Oct 31 2018, 5:07 PM
Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 1 2018, 11:01 AM
Addshore moved this task from Test (Verification) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Nov 1 2018, 6:29 PM

Change 470809 merged by jenkins-bot:
[mediawiki/vendor@master] Update data-values/number to 0.10.1

https://gerrit.wikimedia.org/r/470809

gerritbot added a comment.Nov 1 2018, 6:49 PM

Change 470810 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Require at least data-values/number 0.10.1

https://gerrit.wikimedia.org/r/470810

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.3; 2018-11-06).Nov 1 2018, 7:00 PM
hoo moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 1 2018, 7:14 PM

Given that this seems to only happen rarely, I think this can wait for the train next week.

gerritbot added a comment.Nov 2 2018, 4:01 AM

Change 471202 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] EditEntity::attemptSave: Fail (don't throw) on redirect

https://gerrit.wikimedia.org/r/471202

Lydia_Pintscher closed this task as Resolved.Nov 9 2018, 2:54 PM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lydia_Pintscher subscribed.

\o/

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits