Page MenuHomePhabricator

"Some parts of the edit form did not reach the server; double-check that your edits are intact and try again."
Open, Needs TriagePublic

Description

When I "publish changes", I am getting this message a lot over the past few weeks. What does it mean? What am I supposed to do about it? And, most of all, how can I stop it happening? How can I tell what parts have reached the server? Could there be some kind of diff button to compare it with the version in my browser? And what do iI do if they are different? I've taken the view that what I want is still in the browser so I just keep doing "publish changes" till it works (which usually seems to work the next time I do it).

Event Timeline

If you see this error in the visual editor, that is very unexpected. We've had a problem recently (now fixed) where this error was incorrectly appearing when switching from visual to wikitext editing (T199554). But it should never appear when using just the visual editor.

When you encounter the problem the next time, can you take a screenshot and upload it here? I would like to see how exactly it looks like.

What does it mean? What am I supposed to do about it? And, most of all, how can I stop it happening? How can I tell what parts have reached the server? Could there be some kind of diff button to compare it with the version in my browser? And what do iI do if they are different?

If you get this error message in the old wikitext editor, you should check to see if the page text or edit summary are not cut off, and if they are okay, just try again. (If they are not okay, press Back in your browser and hope that it can restore them.)

(For reference, this message key for this is 'edit_form_incomplete'.)

I've taken the view that what I want is still in the browser so I just keep doing "publish changes" till it works

Yes, seems like a reasonable assumption :)

Duplicate of T254647 reported for Extension:PageForms

@matmarex I am seeing this on https://mediawiki.org just now.

It happened about 4 times between 13:20 and 14:00 (UTC).

It only occurred when I had the preview ("Show preview) or diff ("Show changes") loaded and then refreshed the browser page.

I saw it on pages https://www.mediawiki.org/w/index.php?title=API:Alllinks/Sample_code_1&action=submit and https://www.mediawiki.org/w/index.php?title=Talk_pages_consultation_2019/Communication&action=submit.

Perhaps someone could check the logs.

preview_edit_form_reach_server.png (1×1 px, 63 KB)

Does it only happen with real-time preview enabled? Maybe it is accidentally losing something from the edit form.

Does it only happen with real-time preview enabled? Maybe it is accidentally losing something from the edit form.

So far it has only happened with realtime preview enabled. However, I don't see how it could cause this because the bug appears to be server-side, whereas RTP is client-side.

Inspecting the requests in the network tab, I see that the response from the POST request when you refresh the page shows the editing textbox to be empty. So the server is returning empty data, rather than it being removed after loading.

I was thinking that, since real-time preview rearranges the edit form around, it might remove some elements, and then the request to the server would be missing them. But I was just guessing.

The behavior you're describing could also result from the POST data not including the editing textbox.

Anyway, I'm just guessing. I don't know if we even have any logs for this…

So it looks like there's some logging happening here: https://github.com/wikimedia/mediawiki/blob/master/includes/EditPage.php#L4340

I think this should show up as 'incomplete_form' on https://graphite.wikimedia.org in Metrics → MediaWiki → edit → failures. But it's not there:

image.png (216×388 px, 23 KB)

I don't know if this means 0 results, or if it means the data is not being recorded.

I also looked at 'editattemptstep' schema logging, and there are no events with that error (I'm not sure how they would be represented, but I searched for "form" and "incomplete" and found nothing).