Page MenuHomePhabricator
Create Task
Maniphest T208516

CX2: Link card UI regressions
Closed, ResolvedPublic
Actions

Description

After last full-code update, the link cards look partially broken:

image.png (498×627 px, 24 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/ContentTranslationmaster+5 -0Fix issue card button group wrapping
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Nov 1 2018, 4:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2018, 4:07 PM
Pginer-WMF triaged this task as High priority.Nov 2 2018, 8:07 AM
Pginer-WMF added a project: Language-Team (Language-2018-October-December).
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2018-October-December) board.
Nikerabbit added a comment.Nov 5 2018, 7:31 AM

T208705 looks related.

gerritbot added a subscriber: gerritbot.Nov 5 2018, 2:09 PM

Change 471732 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Fix issue card button group wrapping

https://gerrit.wikimedia.org/r/471732

gerritbot added a project: Patch-For-Review.Nov 5 2018, 2:09 PM
• Petar.petkovic claimed this task.Nov 5 2018, 2:11 PM
• Petar.petkovic moved this task from Priority backlog to In Review on the Language-Team (Language-2018-October-December) board.
• Petar.petkovic moved this task from Needs Triage to Bugs on the ContentTranslation board.
matmarex added a subscriber: matmarex.Nov 5 2018, 6:49 PM

The link card/context was fixed in VE per T208596, this patch fixes the issues card.

matmarex mentioned this in T112982: OOUI ButtonSelectWidget/ButtonGroupWidget not fluid - breaks surveys with multiple buttons.Nov 5 2018, 6:51 PM
gerritbot added a comment.Nov 5 2018, 9:36 PM

Change 471732 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix issue card button group wrapping

https://gerrit.wikimedia.org/r/471732

• Petar.petkovic removed a project: Patch-For-Review.Nov 5 2018, 9:52 PM
• Petar.petkovic moved this task from In Review to QA on the Language-Team (Language-2018-October-December) board.
• Petar.petkovic removed a subscriber: gerritbot.
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 6 2018, 7:02 PM
Pginer-WMF closed this task as Resolved.Nov 12 2018, 11:01 AM
Pginer-WMF moved this task from QA to Done on the Language-Team (Language-2018-October-December) board.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL