Maniphest T208592

Move Senses above Forms
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Problem:
Editors would like to have Senses first as they are more meaningful to help understand what the word is about. Forms can come after that. We should switch them around - both in the UI and diffs.

BDD
GIVEN a Lexeme with Forms and Senses
WHEN viewing the page
THEN Senses are displayed before Forms

GIVEN a diff containing Lexeme edits
AND the diff involves Forms and Senses
WHEN viewing the diff
THEN Senses parts come before Form parts

Acceptance criteria:

Senses are shown before Forms in the UI
Senses are shown before Forms in diffs

Details

	Subject	Repo	Branch	Lines +/-
	Swap form and sense place in view and diff	mediawiki/extensions/WikibaseLexeme	master	+9 -8

Customize query in gerrit

Related Objects

Mentioned In: rEWLE596f520b9939: Swap form and sense place in view and diff
rEWLE9ae28a76c8ca: Swap form and sense place in view and diff
rEWLEbbfa996559c3: Swap form and sense place in view and diff
rEWLEb4b9dc0c5a7d: Swap form and sense place in view and diff

Event Timeline

Lydia_Pintscher created this task.Nov 2 2018, 3:05 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptNov 2 2018, 3:05 PM

Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Nov 2 2018, 3:05 PM

Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.

Lydia_Pintscher moved this task from incoming to features/bugs for next release (Lexeme page) on the Wikidata Lexicographical data board.

KaMan subscribed.Nov 2 2018, 3:49 PM

Addshore triaged this task as Medium priority.Nov 6 2018, 11:15 AM

I will do this :D

Change 471952 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Swap form and sense place in view and diff

https://gerrit.wikimedia.org/r/471952

gerritbot added a project: Patch-For-Review.Nov 6 2018, 1:04 PM

Ladsgroup mentioned this in rEWLEb4b9dc0c5a7d: Swap form and sense place in view and diff.Nov 6 2018, 1:04 PM

Ladsgroup mentioned this in rEWLEbbfa996559c3: Swap form and sense place in view and diff.Nov 6 2018, 1:11 PM

Ladsgroup mentioned this in rEWLE9ae28a76c8ca: Swap form and sense place in view and diff.Nov 6 2018, 1:22 PM

Addshore renamed this task from Move Senses before Forms to Move Senses above Forms.Nov 6 2018, 2:25 PM

Addshore set the point value for this task to 3.Nov 6 2018, 2:31 PM

Addshore moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.

Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Change 471996 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Swap form and sense place in view and diff

https://gerrit.wikimedia.org/r/471996

Ladsgroup mentioned this in rEWLE596f520b9939: Swap form and sense place in view and diff.Nov 6 2018, 4:12 PM

Ladsgroup claimed this task.Nov 6 2018, 4:17 PM

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptNov 6 2018, 4:17 PM

Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 6 2018, 4:19 PM

Change 471996 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Swap form and sense place in view and diff

https://gerrit.wikimedia.org/r/471996

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Nov 6 2018, 5:37 PM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.4; 2018-11-13).Nov 6 2018, 8:00 PM