Maniphest T209576

Remove BC for old entitytermsview cookies
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Backwards compatibility code is unneeded after 2018-11-14 per the comment in the code and can be removed. The cookie wikibase-entitytermsview-showEntitytermslistview is now always prefixed.

https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/0924869ff8ccb59c4fe20d0060e50c87d26ad4f1/repo/includes/ParserOutput/EntityViewPlaceholderExpander.php#168

Details

	Subject	Repo	Branch	Lines +/-
	Collapsed termbox state: fix/simplify cookie	mediawiki/extensions/Wikibase	master	+17 -25
	Drop the B/C code for cookies	mediawiki/extensions/Wikibase	master	+0 -25

Customize query in gerrit

Related Objects

Mentioned In: T209496: "In more languages" toggle state persistence

Event Timeline

• Pablo-WMDE created this task.Nov 15 2018, 11:11 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2018, 11:11 AM

• Pablo-WMDE mentioned this in T209496: "In more languages" toggle state persistence.Nov 15 2018, 11:19 AM

Addshore added a project: Technical-Debt.Nov 16 2018, 4:07 PM

Addshore triaged this task as Low priority.Dec 4 2018, 9:47 AM

Addshore raised the priority of this task from Low to Needs Triage.

Addshore added a project: Wikidata-Campsite.

Addshore moved this task from incoming to consider for next sprint on the Wikidata board.

Addshore moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.

Addshore triaged this task as Low priority.Dec 6 2018, 10:58 AM

Lucas_Werkmeister_WMDE set the point value for this task to 3.Dec 11 2018, 3:56 PM

Lucas_Werkmeister_WMDE moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.

Lucas_Werkmeister_WMDE edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Change 480532 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Drop the B/C code for cookies

https://gerrit.wikimedia.org/r/480532

gerritbot added a project: Patch-For-Review.Dec 18 2018, 4:33 PM

Ladsgroup claimed this task.Dec 18 2018, 4:33 PM

Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 18 2018, 4:33 PM

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Dec 19 2018, 11:58 AM

Change 480532 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Drop the B/C code for cookies

https://gerrit.wikimedia.org/r/480532

Addshore moved this task from consider for next sprint to in progress on the Wikidata board.Dec 19 2018, 12:44 PM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Dec 19 2018, 1:00 PM

Nothing to really verify here

Change 491250 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] Collapsed termbox state: fix/simplify cookie

https://gerrit.wikimedia.org/r/491250

Change 491250 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Collapsed termbox state: fix/simplify cookie