Page MenuHomePhabricator
Create Task
Maniphest T209619

Broken "HON" browser plug-in causes content corruption when editing
Closed, ResolvedPublic
Actions

Description

Reported by @Doc_James on https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback:

<div target="_blank" id="honLogo_50" class="hon certificateLink honcode-logo-wide valid" title="HONcode certified" alt="HONcode certified" href="http://services.hon.ch/cgi-bin/Plugin/redirect.pl?HONConduct982312+en"></div>
<div target="_blank" id="honLogo_56" class="hon certificateLink honcode-logo-wide valid" title="HONcode certified" alt="HONcode certified" href="http://services.hon.ch/cgi-bin/Plugin/redirect.pl?HONConduct278812+en"></div>
<div target="_blank" id="honLogo_162" class="hon certificateLink honcode-logo-wide valid" title="HONcode certified" alt="HONcode certified" href="http://services.hon.ch/cgi-bin/Plugin/redirect.pl?HONConduct788421+en"></div>
<div target="_blank" id="honLogo_298" class="hon certificateLink honcode-logo-wide"></div>
<div target="_blank" id="honLogo_352" class="hon certificateLink honcode-logo-wide valid" title="HONcode certified" alt="HONcode certified" href="http://services.hon.ch/cgi-bin/Plugin/redirect.pl?HONConduct756274+en"></div>

Lovely.

Details

SubjectRepoBranchLines +/-
Fix filtering out .donut-container againmediawiki/extensions/VisualEditorwmf/1.33.0-wmf.6+1 -1
Fix filtering out .donut-container againmediawiki/extensions/VisualEditormaster+1 -1
Filter out junk from the HON browser plug-inmediawiki/extensions/VisualEditormaster+1 -0
Customize query in gerrit

Event Timeline

Jdforrester-WMF created this task.Nov 15 2018, 6:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 15 2018, 6:19 PM
gerritbot subscribed.Nov 15 2018, 6:23 PM

Change 473809 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Filter out junk from the HON browser plug-in

https://gerrit.wikimedia.org/r/473809

gerritbot added a project: Patch-For-Review.Nov 15 2018, 6:23 PM
gerritbot added a comment.Nov 20 2018, 3:51 PM

Change 473809 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Filter out junk from the HON browser plug-in

https://gerrit.wikimedia.org/r/473809

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 20 2018, 4:00 PM
Jdforrester-WMF claimed this task.Nov 20 2018, 4:04 PM
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki, VisualEditor (Current work); removed Patch-For-Review, VisualEditor.
Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.
Ryasmeen added a project: Editing QA.Nov 26 2018, 6:53 PM
gerritbot added a comment.Dec 11 2018, 12:12 AM

Change 478808 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Fix filtering out .donut-container again

https://gerrit.wikimedia.org/r/478808

gerritbot added a project: Patch-For-Review.Dec 11 2018, 12:12 AM
gerritbot added a comment.Dec 11 2018, 1:11 PM

Change 478808 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix filtering out .donut-container again

https://gerrit.wikimedia.org/r/478808

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.9; 2018-12-18); removed MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Dec 11 2018, 3:01 PM
gerritbot added a comment.Dec 11 2018, 4:13 PM

Change 478975 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.33.0-wmf.6] Fix filtering out .donut-container again

https://gerrit.wikimedia.org/r/478975

gerritbot added a comment.Dec 11 2018, 7:18 PM

Change 478975 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.33.0-wmf.6] Fix filtering out .donut-container again

https://gerrit.wikimedia.org/r/478975

Stashbot subscribed.Dec 11 2018, 7:22 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-11T19:22:50Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.6/extensions/VisualEditor/modules/ve-mw/init/ve.init.mw.Target.js: T209619: Hot-deploy Ibcf3c93e (duration: 00m 52s)

Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.6; 2018-11-27); removed MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review.Dec 11 2018, 7:28 PM
matmarex moved this task from QA to Engineering QA on the VisualEditor (Current work) board.Dec 11 2018, 11:47 PM
matmarex moved this task from Engineering QA to Product owner review on the VisualEditor (Current work) board.
• marcella removed a project: Editing QA.Dec 13 2018, 3:32 PM
• marcella closed this task as Resolved.Dec 14 2018, 4:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL