Page MenuHomePhabricator
Create Task
Maniphest T210091

Pageviews top endpoint in descending order as of 2018-11-20
Closed, ResolvedPublic
Actions

Description

The daily top pageviews endpoint is in descending order on November 11, 2018:
https://wikimedia.org/api/rest_v1/metrics/pageviews/top/en.wikipedia/all-access/2018/11/20

All previous days are in ascending, as expected:
https://wikimedia.org/api/rest_v1/metrics/pageviews/top/en.wikipedia/all-access/2018/11/19
https://wikimedia.org/api/rest_v1/metrics/pageviews/top/en.wikipedia/all-access/2018/11/18
etc.

Is this intentional? If so, could we change it so that all endpoints are consistent? Though I would argue ascending order makes the most sense.

Details

SubjectRepoBranchLines +/-
Sort articles by rank in top endpointanalytics/aqsmaster+52 -52
Customize query in gerrit

Related Objects

Event Timeline

MusikAnimal created this task.Nov 21 2018, 4:02 PM
Restricted Application added a project: Analytics. · View Herald TranscriptNov 21 2018, 4:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Milimetric claimed this task.Nov 21 2018, 5:12 PM
Milimetric triaged this task as High priority.
Milimetric added a project: Analytics-Kanban.
Milimetric moved this task from Next Up to In Progress on the Analytics-Kanban board.
• Nuria subscribed.EditedNov 21 2018, 6:40 PM

Problem found, was due to a deployment we did yesterday that changed one of our dependencies, we will file bug to services team for that but should be easy to fix this issue on our end.

gerritbot subscribed.Nov 21 2018, 6:58 PM

Change 475131 had a related patch set uploaded (by Milimetric; owner: Milimetric):
[analytics/aqs@master] Sort articles by rank in top endpoint

https://gerrit.wikimedia.org/r/475131

gerritbot added a project: Patch-For-Review.Nov 21 2018, 6:58 PM
Milimetric mentioned this in T210105: Cassandra JSON fields getting reversed.Nov 21 2018, 7:04 PM
gerritbot added a comment.Nov 21 2018, 7:25 PM

Change 475131 merged by Nuria:
[analytics/aqs@master] Sort articles by rank in top endpoint

https://gerrit.wikimedia.org/r/475131

Milimetric moved this task from In Progress to Done on the Analytics-Kanban board.Nov 21 2018, 7:55 PM
Milimetric moved this task from Incoming to Operational Excellence on the Analytics board.Nov 21 2018, 8:15 PM

The fix for this has been deployed, but it'll take a while to clear the cache. Sorry for the inconvenience.

• Mholloway subscribed.Nov 22 2018, 12:28 AM
• bearND subscribed.Nov 22 2018, 12:32 AM
Milimetric added a comment.Nov 26 2018, 4:39 PM

Just to follow up to put this issue to rest, the caches are all cleared and the responses are all consistent, going from rank 1 to rank 1000 in order. This is a sort at the service level so it won't be affected by underlying libraries anymore.

• Nuria closed this task as Resolved.Dec 10 2018, 5:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits