Unfortunately I didn't catch this before, but the access date from the new Zotero is a full iso date containing the time stamp. We should strip this in lib/Exporter.js
Description
Details
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
mediawiki/services/citoid | master | +3 -4 | Strip time from accessDate |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Sebastian_Berlin-WMSE | T187023 Create Zotero translator for sverigesradio.se | |||
Resolved | Krenair | T204500 cloudvps: deployment-prep project trusty deprecation | |||
Resolved | None | T204467 Update Citoid with translators for Swedish news sites | |||
Resolved | Mvolz | T197242 Transition citoid to use Zotero's translation-server-v2 | |||
Resolved | akosiaris | T211114 Some regressions in production with Zotero translation-server in production | |||
Resolved | Mvolz | T211127 The new translation-server returns access date with the full time stamp; we should strip this |
Event Timeline
@Jdforrester-WMF Unfortunately I'm going to be on an aeroplane both today and tomorrow and I'm not sure what the ETA on deploying the fix will look like. It gives a CS1 error in production right now, I think we'll get a lot of complaints.
Reported so far at the following venues (that I have seen):
https://en.wikipedia.org/wiki/Wikipedia_talk:ProveIt#Time_in_access_date
https://en.wikipedia.org/wiki/Help_talk:Citation_Style_1#accessdate_errors
People aren't freaking out yet, but they are somewhat bothered. If it is possible to back out this change without too much trouble, I'm sure it would be appreciated.
Change 477714 had a related patch set uploaded (by Mvolz; owner: Mvolz):
[mediawiki/services/citoid@master] Strip time from accessDate
Change 477714 merged by Mobrovac:
[mediawiki/services/citoid@master] Strip time from accessDate
Mentioned in SAL (#wikimedia-operations) [2018-12-05T11:23:02Z] <mobrovac@deploy1001> Started deploy [citoid/deploy@b10e034]: Truncate Zotero-reported time stamp to date - T211127
Mentioned in SAL (#wikimedia-operations) [2018-12-05T11:28:58Z] <mobrovac@deploy1001> Finished deploy [citoid/deploy@b10e034]: Truncate Zotero-reported time stamp to date - T211127 (duration: 05m 55s)