The new translation-server returns access date with the full time stamp; we should strip this
Closed, ResolvedPublic

Description

Unfortunately I didn't catch this before, but the access date from the new Zotero is a full iso date containing the time stamp. We should strip this in lib/Exporter.js

Mvolz created this task.Tue, Dec 4, 4:35 PM
Mvolz triaged this task as Normal priority.
Mvolz added a comment.Tue, Dec 4, 4:43 PM

@Jdforrester-WMF Unfortunately I'm going to be on an aeroplane both today and tomorrow and I'm not sure what the ETA on deploying the fix will look like. It gives a CS1 error in production right now, I think we'll get a lot of complaints.

Mvolz raised the priority of this task from Normal to Unbreak Now!.Tue, Dec 4, 4:43 PM
Jonesey95 added a subscriber: Jonesey95.EditedWed, Dec 5, 2:53 AM

Reported so far at the following venues (that I have seen):

https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#on_iPhone_Auto_citation_tool_produced_access-date_with_TZ_code_and_time_that_produced_an_error

https://en.wikipedia.org/wiki/Wikipedia_talk:ProveIt#Time_in_access_date

https://en.wikipedia.org/wiki/Help_talk:Citation_Style_1#accessdate_errors

People aren't freaking out yet, but they are somewhat bothered. If it is possible to back out this change without too much trouble, I'm sure it would be appreciated.

Change 477714 had a related patch set uploaded (by Mvolz; owner: Mvolz):
[mediawiki/services/citoid@master] Strip time from accessDate

https://gerrit.wikimedia.org/r/477714

Change 477714 merged by Mobrovac:
[mediawiki/services/citoid@master] Strip time from accessDate

https://gerrit.wikimedia.org/r/477714

Mentioned in SAL (#wikimedia-operations) [2018-12-05T11:23:02Z] <mobrovac@deploy1001> Started deploy [citoid/deploy@b10e034]: Truncate Zotero-reported time stamp to date - T211127

Mentioned in SAL (#wikimedia-operations) [2018-12-05T11:28:58Z] <mobrovac@deploy1001> Finished deploy [citoid/deploy@b10e034]: Truncate Zotero-reported time stamp to date - T211127 (duration: 05m 55s)

mobrovac lowered the priority of this task from Unbreak Now! to High.Wed, Dec 5, 11:32 AM
mobrovac closed this task as Resolved.
mobrovac assigned this task to Mvolz.
mobrovac removed a project: Patch-For-Review.

Deployed, should be fixed now. Please reopen if that's not the case.