Page MenuHomePhabricator

The new translation-server returns access date with the full time stamp; we should strip this
Closed, ResolvedPublic


Unfortunately I didn't catch this before, but the access date from the new Zotero is a full iso date containing the time stamp. We should strip this in lib/Exporter.js

Event Timeline

Mvolz triaged this task as Medium priority.Dec 4 2018, 4:35 PM
Mvolz created this task.

@Jdforrester-WMF Unfortunately I'm going to be on an aeroplane both today and tomorrow and I'm not sure what the ETA on deploying the fix will look like. It gives a CS1 error in production right now, I think we'll get a lot of complaints.

Mvolz raised the priority of this task from Medium to Unbreak Now!.Dec 4 2018, 4:43 PM

Reported so far at the following venues (that I have seen):

People aren't freaking out yet, but they are somewhat bothered. If it is possible to back out this change without too much trouble, I'm sure it would be appreciated.

Change 477714 had a related patch set uploaded (by Mvolz; owner: Mvolz):
[mediawiki/services/citoid@master] Strip time from accessDate

Change 477714 merged by Mobrovac:
[mediawiki/services/citoid@master] Strip time from accessDate

Mentioned in SAL (#wikimedia-operations) [2018-12-05T11:23:02Z] <mobrovac@deploy1001> Started deploy [citoid/deploy@b10e034]: Truncate Zotero-reported time stamp to date - T211127

Mentioned in SAL (#wikimedia-operations) [2018-12-05T11:28:58Z] <mobrovac@deploy1001> Finished deploy [citoid/deploy@b10e034]: Truncate Zotero-reported time stamp to date - T211127 (duration: 05m 55s)

mobrovac assigned this task to Mvolz.
mobrovac lowered the priority of this task from Unbreak Now! to High.
mobrovac removed a project: Patch-For-Review.

Deployed, should be fixed now. Please reopen if that's not the case.