Page MenuHomePhabricator
Create Task
Maniphest T211370

Help panel: create API module for posting messages to help desk, remove MessagePoster implementation
Closed, ResolvedPublic
Actions

Description

The API module will receive a POST request from step two of the help panel "ask a question" flow. It should:

  1. Save the user's email, if a new one was supplied
  2. send a verification email if the user's address is not yet confirmed.
  3. Create a new section header on the help desk, and append a timestamp.
  4. Post the received text with signature as an edit from the authorized user, using a help-panel tag (T211118)
  5. Return a response containing:
    1. success or error message & error code
    2. the section header, so that we can construct a link to take the user directly to their question on help desk
    3. the user's edit count after making the edit with the request.

The second part of this task is removing the MessagePoster implementation in favor of the new API module.

Details

SubjectRepoBranchLines +/-
Help Panel: Add API module to post questionsmediawiki/extensions/GrowthExperimentsmaster+622 -73
Customize query in gerrit

Related Objects
Search...

Event Timeline

kostajh created this task.Dec 6 2018, 8:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 6 2018, 8:09 PM
kostajh renamed this task from Create API module for posting messages to help desk to Create API module for posting messages to help desk, remove MessagePoster implementation.Dec 6 2018, 8:10 PM
kostajh added a parent task: T209318: Help panel: allow users to "Ask a question" to help desk.
kostajh updated the task description. (Show Details)
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh updated the task description. (Show Details)Dec 7 2018, 4:05 PM
kostajh mentioned this in rEGRE7bd7a7d5c31c: Help Panel: UI updates for different email statuses.Dec 7 2018, 5:49 PM
kostajh mentioned this in rEGRE904ca3aa9ab2: Help Panel: UI updates for different email statuses.Dec 7 2018, 6:00 PM
kostajh mentioned this in rEGRE1626c32fd1ba: Help Panel: UI updates for different email statuses.Dec 7 2018, 6:07 PM
kostajh mentioned this in rEGRE64df2f2f21f6: Help Panel: UI updates for different email statuses.Dec 7 2018, 7:17 PM
kostajh mentioned this in rEGREc851444e6055: Help Panel: UI updates for different email statuses.Dec 7 2018, 7:23 PM
kostajh mentioned this in rEGRE16e192025000: Help Panel: UI updates for different email statuses.Dec 7 2018, 8:19 PM
kostajh mentioned this in rEGRE004c6fe7f6a5: Help Panel: UI updates for different email statuses.Dec 7 2018, 8:35 PM
kostajh mentioned this in rEGRE00b742d9523a: Help Panel: UI updates for different email statuses.Dec 7 2018, 8:38 PM
kostajh mentioned this in rEGREd019d82e75bb: Help Panel: UI updates for different email statuses.Dec 7 2018, 8:52 PM
kostajh mentioned this in rEGREde12c867405a: Help Panel: UI updates for different email statuses.Dec 7 2018, 9:32 PM
kostajh claimed this task.Dec 7 2018, 9:50 PM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh removed kostajh as the assignee of this task.Dec 7 2018, 9:57 PM
kostajh moved this task from In Progress to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

Unassigning for now since I'm about to sign off for the day.

kostajh mentioned this in rEGRE935ef63b69c1: Help Panel: UI updates for different email statuses.Dec 10 2018, 2:34 PM
kostajh mentioned this in rEGRE112e7184496f: Help Panel: UI updates for different email statuses.Dec 10 2018, 3:41 PM
kostajh mentioned this in rEGRE2643b0099f19: Help Panel: UI updates for different email statuses.Dec 10 2018, 3:51 PM
kostajh claimed this task.Dec 10 2018, 3:54 PM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh mentioned this in rEGRE1819148f90b5: Help Panel: UI updates for different email statuses.Dec 10 2018, 4:03 PM
gerritbot subscribed.Dec 10 2018, 8:14 PM

Change 478769 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] WIP: Help Panel: Add API module to post questions

https://gerrit.wikimedia.org/r/478769

gerritbot added a project: Patch-For-Review.Dec 10 2018, 8:14 PM
kostajh mentioned this in rEGRE2b63f68a00ca: WIP: Help Panel: Add API module to post questions.Dec 10 2018, 8:15 PM
kostajh mentioned this in rEGREd39956444035: WIP: Help Panel: Add API module to post questions.Dec 10 2018, 8:26 PM
kostajh mentioned this in rEGRE10fabddda8ac: WIP: Help Panel: Add API module to post questions.Dec 11 2018, 3:42 AM
kostajh mentioned this in rEGRE51f131c7c9a5: WIP: Help Panel: Add API module to post questions.Dec 11 2018, 6:15 PM
kostajh mentioned this in rEGRE97c30c78700b: WIP: Help Panel: Add API module to post questions.Dec 11 2018, 6:18 PM
kostajh mentioned this in rEGREc29c1d8a037e: WIP: Help Panel: Add API module to post questions.Dec 11 2018, 7:37 PM
MMiller_WMF renamed this task from Create API module for posting messages to help desk, remove MessagePoster implementation to Help panel: create API module for posting messages to help desk, remove MessagePoster implementation.Dec 11 2018, 10:37 PM
MMiller_WMF subscribed.
kostajh mentioned this in rEGRE6e69df7f720d: WIP: Help Panel: Add API module to post questions.Dec 11 2018, 11:00 PM
kostajh mentioned this in rEGRE95d76ea86a3b: WIP: Help Panel: Add API module to post questions.Dec 12 2018, 2:33 AM
kostajh mentioned this in rEGRE866e57b28668: WIP: Help Panel: Add API module to post questions.Dec 12 2018, 2:46 AM
kostajh mentioned this in rEGREdab732644dd7: WIP: Help Panel: Add API module to post questions.Dec 12 2018, 2:50 AM
kostajh mentioned this in rEGRE4be41f93492e: WIP: Help Panel: Add API module to post questions.Dec 12 2018, 3:06 AM
kostajh mentioned this in rEGRE3c6d26ffe488: WIP: Help Panel: Add API module to post questions.Dec 12 2018, 3:23 AM
kostajh mentioned this in rEGRE9fd18f177469: WIP: Help Panel: Add API module to post questions.Dec 12 2018, 9:51 PM
kostajh mentioned this in rEGREce6a0ca555d9: Help Panel: Add API module to post questions.Dec 12 2018, 10:13 PM
kostajh mentioned this in rEGRE654a602a5e06: Help Panel: Add API module to post questions.Dec 12 2018, 10:46 PM
kostajh mentioned this in rEGREa648d20b0793: Help Panel: Add API module to post questions.Dec 13 2018, 1:47 AM
kostajh mentioned this in T211113: Help panel: allow users to supply an email address.Dec 13 2018, 5:53 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh updated the task description. (Show Details)
kostajh mentioned this in rEGREb5c595ccbf58: Help Panel: Add API module to post questions.Dec 13 2018, 7:41 PM
gerritbot added a comment.Dec 13 2018, 8:05 PM

Change 478769 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help Panel: Add API module to post questions

https://gerrit.wikimedia.org/r/478769

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 13 2018, 8:36 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 13 2018, 9:00 PM
Etonkovidova closed this task as Resolved.Dec 21 2018, 1:05 AM
Etonkovidova subscribed.

Checked in betalabs api - works as expected - e.g.

{
    "helppanelquestionposter": {
        "result": "success",
        "revision": 387966,
        "isfirstedit": 0,
        "viewquestionurl": "https://en.wikipedia.beta.wmflabs.org/wiki/Wikipedia:Help_desk#Help_panel_question_(01:00,_21_December_2018)",
        "email": "already_confirmed"
    }
}

The questions are correctly posted and email address is correctly identified as confirmed or as non-confirmed.

kostajh mentioned this in T223442: Homepage: include the section link on Mentorship module's questions' edit summaries.May 30 2019, 1:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL