Page MenuHomePhabricator
Create Task
Maniphest T211484

UploadBlacklist is missing licensing
Closed, ResolvedPublic
Actions

Description

https://www.mediawiki.org/wiki/Extension:UploadBlacklist nor https://github.com/wikimedia/mediawiki-extensions-UploadBlacklist contains any licensing indication. @brion is its author.

Details

SubjectRepoBranchLines +/-
Add GPLv2+ 'COPYING' file for old extensionmediawiki/extensions/UploadBlacklistREL1_33+342 -0
Add GPLv2+ 'COPYING' file for old extensionmediawiki/extensions/UploadBlacklistREL1_34+342 -0
Add GPLv2+ 'COPYING' file for old extensionmediawiki/extensions/UploadBlacklistREL1_31+342 -0
Add GPLv2+ 'COPYING' file for old extensionmediawiki/extensions/UploadBlacklistmaster+342 -0
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedMarcoAurelioT211483 Convert UploadBlacklist to use extension registration
Resolved• brionT211484 UploadBlacklist is missing licensing
· · ·

Event Timeline

MarcoAurelio created this task.Dec 8 2018, 9:32 PM
MarcoAurelio moved this task from Backlog to Missing/unspecified license on the Software-Licensing board.
Aklapper added a comment.Aug 9 2019, 4:06 AM

First git commit says

Author: Brion Vibber <brion@users.mediawiki.org>
Date:   Tue Jul 14 21:49:50 2009 +0000
    Commit little UploadBlacklist extension we've had live for a few years but apparently forgot to commit. ;)
    It's pretty hacky, requiring sysadmins to add SHA-1 hashes to an array (haha! yeah that's scalable)
    Should get rewritten with a DB and a UI and integrated to core at some point.

hence not sure if @brion is the original author. @brion, could you clarify? And if you are the author, also clarify the license? TIA!

• brion added a comment.Feb 9 2020, 7:35 AM

I think I wrote this yes... we'd consider this as GPLv2-or-later as part of MediaWiki. It wasn't originally labeled in detail as it was a one-off production hack that ended up being kept around, and we weren't as careful with explicit labeling on extensions back then.

gerritbot added a comment.Feb 9 2020, 7:43 AM

Change 571037 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/UploadBlacklist@master] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571037

gerritbot added a project: Patch-For-Review.Feb 9 2020, 7:43 AM
gerritbot added a comment.Feb 9 2020, 12:48 PM

Change 571037 merged by jenkins-bot:
[mediawiki/extensions/UploadBlacklist@master] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571037

gerritbot added a comment.Feb 9 2020, 12:48 PM

Change 571055 had a related patch set uploaded (by MarcoAurelio; owner: Brion VIBBER):
[mediawiki/extensions/UploadBlacklist@REL1_34] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571055

gerritbot added a comment.Feb 9 2020, 12:49 PM

Change 571056 had a related patch set uploaded (by MarcoAurelio; owner: Brion VIBBER):
[mediawiki/extensions/UploadBlacklist@REL1_33] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571056

gerritbot added a comment.Feb 9 2020, 12:49 PM

Change 571057 had a related patch set uploaded (by MarcoAurelio; owner: Brion VIBBER):
[mediawiki/extensions/UploadBlacklist@REL1_31] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571057

gerritbot added a comment.Feb 9 2020, 12:50 PM

Change 571056 abandoned by MarcoAurelio:
Add GPLv2 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571056

gerritbot added a comment.Feb 9 2020, 12:51 PM

Change 571056 restored by MarcoAurelio:
Add GPLv2 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571056

MarcoAurelio added a subscriber: Legoktm.Feb 9 2020, 12:58 PM

@brion @Legoktm I've merged Brion's patch on master and cherry-picked to REL1_31, 33 and 34 just in case that's needed. I've not merged those. Please take a look if you can/want and decide whether they're needed or not :) Thanks.

Legoktm closed this task as Resolved.Feb 10 2020, 7:34 PM
Legoktm assigned this task to • brion.

woot, thanks @brion.

In T211484#5862606, @MarcoAurelio wrote:

@brion @Legoktm I've merged Brion's patch on master and cherry-picked to REL1_31, 33 and 34 just in case that's needed. I've not merged those. Please take a look if you can/want and decide whether they're needed or not :) Thanks.

+2'd, thank you.

gerritbot added a comment.Feb 10 2020, 7:36 PM

Change 571057 merged by jenkins-bot:
[mediawiki/extensions/UploadBlacklist@REL1_31] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571057

gerritbot added a comment.Feb 10 2020, 7:36 PM

Change 571055 merged by jenkins-bot:
[mediawiki/extensions/UploadBlacklist@REL1_34] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571055

gerritbot added a comment.Feb 10 2020, 7:37 PM

Change 571056 merged by jenkins-bot:
[mediawiki/extensions/UploadBlacklist@REL1_33] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571056

MarcoAurelio added a comment.Feb 10 2020, 7:54 PM

Meow ^_^

MarcoAurelio removed a project: Patch-For-Review.Feb 10 2020, 7:54 PM
Peachey88 edited projects, added MediaWiki-extensions-UploadBlacklist; removed MediaWiki-extensions-Other.Feb 23 2020, 1:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL