Page MenuHomePhabricator

UploadBlacklist is missing licensing
Closed, ResolvedPublic

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
Resolved MarcoAurelio
Resolvedbrion

Event Timeline

First git commit says

Author: Brion Vibber <brion@users.mediawiki.org>
Date:   Tue Jul 14 21:49:50 2009 +0000
    Commit little UploadBlacklist extension we've had live for a few years but apparently forgot to commit. ;)
    It's pretty hacky, requiring sysadmins to add SHA-1 hashes to an array (haha! yeah that's scalable)
    Should get rewritten with a DB and a UI and integrated to core at some point.

hence not sure if @brion is the original author. @brion, could you clarify? And if you are the author, also clarify the license? TIA!

brion added a comment.Feb 9 2020, 7:35 AM

I think I wrote this yes... we'd consider this as GPLv2-or-later as part of MediaWiki. It wasn't originally labeled in detail as it was a one-off production hack that ended up being kept around, and we weren't as careful with explicit labeling on extensions back then.

Change 571037 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/UploadBlacklist@master] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571037

Change 571037 merged by jenkins-bot:
[mediawiki/extensions/UploadBlacklist@master] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571037

Change 571055 had a related patch set uploaded (by MarcoAurelio; owner: Brion VIBBER):
[mediawiki/extensions/UploadBlacklist@REL1_34] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571055

Change 571056 had a related patch set uploaded (by MarcoAurelio; owner: Brion VIBBER):
[mediawiki/extensions/UploadBlacklist@REL1_33] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571056

Change 571057 had a related patch set uploaded (by MarcoAurelio; owner: Brion VIBBER):
[mediawiki/extensions/UploadBlacklist@REL1_31] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571057

Change 571056 abandoned by MarcoAurelio:
Add GPLv2 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571056

Change 571056 restored by MarcoAurelio:
Add GPLv2 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571056

@brion @Legoktm I've merged Brion's patch on master and cherry-picked to REL1_31, 33 and 34 just in case that's needed. I've not merged those. Please take a look if you can/want and decide whether they're needed or not :) Thanks.

Legoktm closed this task as Resolved.Feb 10 2020, 7:34 PM
Legoktm assigned this task to brion.

woot, thanks @brion.

@brion @Legoktm I've merged Brion's patch on master and cherry-picked to REL1_31, 33 and 34 just in case that's needed. I've not merged those. Please take a look if you can/want and decide whether they're needed or not :) Thanks.

+2'd, thank you.

Change 571057 merged by jenkins-bot:
[mediawiki/extensions/UploadBlacklist@REL1_31] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571057

Change 571055 merged by jenkins-bot:
[mediawiki/extensions/UploadBlacklist@REL1_34] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571055

Change 571056 merged by jenkins-bot:
[mediawiki/extensions/UploadBlacklist@REL1_33] Add GPLv2+ 'COPYING' file for old extension

https://gerrit.wikimedia.org/r/571056