Editor summary on mobile does neither receive mediawiki.ui appearance nor inherit font-size
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Volker_E
	Dec 12 2018, 3:29 AM

Description

And the CSS, without inputs: https://m.mediawiki.org/w/load.php?debug=false&lang=en&modules=mediawiki.hlist%7Cmediawiki.ui.button%2Cicon%7Cskins.minerva.base.reset%2Cstyles%7Cskins.minerva.content.styles%7Cskins.minerva.content.styles.images%7Cskins.minerva.icons.images%2Cloggedin%7Cskins.minerva.loggedin.styles%7Cskins.minerva.tablet.styles&only=styles&skin=minerva

Replication steps

Visit https://en.m.wikipedia.org/wiki/Theatre_of_the_United_Kingdom#/editor/0
Type something
Click next
Summary appears unstyled

Developer notes

mw.loader.using('mediawiki.ui.input') fixes the problem. It should be listed as a dependency of the EditorOverlay.

Details

	Subject	Repo	Branch	Lines +/-
	Mediawiki.ui.input should be a dependency of the EditorOverlay	mediawiki/extensions/MobileFrontend	master	+1 -0

Customize query in gerrit

Event Timeline

Volker_E created this task.Dec 12 2018, 3:29 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 12 2018, 3:29 AM

Jdrewniak added a project: VisualEditor-MediaWiki-Mobile.Dec 12 2018, 8:02 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 12 2018, 8:02 PM

Jdlrobson renamed this task from VE summary on mobile does neither receive mediawiki.ui appearance nor inherit font-size to Editor summary on mobile does neither receive mediawiki.ui appearance nor inherit font-size.Dec 12 2018, 11:11 PM

Jdlrobson updated the task description. (Show Details)

(It's also a problem in the non-VE view)

Change 479350 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Mediawiki.ui.input should be a dependency of the EditorOverlay

https://gerrit.wikimedia.org/r/479350

gerritbot added a project: Patch-For-Review.Dec 12 2018, 11:15 PM

After above fix:

Screen Shot 2018-12-12 at 3.15.35 PM.png (674×474 px, 133 KB)

Change 479350 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Mediawiki.ui.input should be a dependency of the EditorOverlay

https://gerrit.wikimedia.org/r/479350

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 13 2018, 12:00 AM

JTannerWMF closed this task as Resolved.Dec 19 2018, 6:51 PM

JTannerWMF claimed this task.

JTannerWMF removed projects: VisualEditor, VisualEditor-MediaWiki-Mobile.

matmarex edited projects, added MobileFrontend; removed MinervaNeue.Dec 19 2018, 6:51 PM

	F27525696: Screen Shot 2018-12-12 at 3.15.35 PM.png
	Dec 12 2018, 11:15 PM

Editor summary on mobile does neither receive mediawiki.ui appearance nor inherit font-sizeClosed, ResolvedPublicActions