Page MenuHomePhabricator

McsContentProviderTest::testGetHtmlWithNoResponse Undefined index: 1
Closed, ResolvedPublic

Description

https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-hhvm-docker/6915/console and https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/479493/

17:27:07 1) McsContentProviderTest::testGetHtmlWithNoResponse
17:27:07 Undefined index: 1
17:27:07 
17:27:07 /workspace/src/includes/http/MWHttpRequest.php:424
17:27:07 /workspace/src/includes/http/CurlHttpRequest.php:138
17:27:07 /workspace/src/extensions/MobileFrontend/includes/content-providers/McsContentProvider.php:61
17:27:07 /workspace/src/extensions/MobileFrontend/includes/content-providers/McsContentProvider.php:81
17:27:07 /workspace/src/extensions/MobileFrontend/tests/phpunit/content-providers/McsContentProviderTest.php:112
17:27:07 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
17:27:07 /workspace/src/maintenance/doMaintenance.php:94

Blocking a partial revert to fix T211886

Event Timeline

Reedy created this task.Dec 13 2018, 5:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2018, 5:33 PM
Reedy triaged this task as High priority.Dec 13 2018, 5:36 PM
Reedy updated the task description. (Show Details)
Reedy added subscribers: pmiazga, D3r1ck01.

Change 479495 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Revert "Add PHPUnit tests for methods in McsContentProvider::class"

https://gerrit.wikimedia.org/r/479495

Change 479495 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Revert "Add PHPUnit tests for methods in McsContentProvider::class"

https://gerrit.wikimedia.org/r/479495

D3r1ck01 closed this task as Resolved.Dec 13 2018, 8:34 PM
D3r1ck01 assigned this task to Jdlrobson.
D3r1ck01 added a subscriber: Jdlrobson.

Resolving this! Thanks for reporting @Reedy and for a quick fix @Jdlrobson.

Change 479551 had a related patch set uploaded (by Reedy; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.8] Revert "Add PHPUnit tests for methods in McsContentProvider::class"

https://gerrit.wikimedia.org/r/479551

Change 479551 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.8] Revert "Add PHPUnit tests for methods in McsContentProvider::class"

https://gerrit.wikimedia.org/r/479551

Mentioned in SAL (#wikimedia-operations) [2018-12-13T22:29:20Z] <reedy@deploy1001> Synchronized php-1.33.0-wmf.8/extensions/MobileFrontend: T211903 (duration: 00m 48s)