Page MenuHomePhabricator
Create Task
Maniphest T211903

McsContentProviderTest::testGetHtmlWithNoResponse Undefined index: 1
Closed, ResolvedPublic
Actions

Description

https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-hhvm-docker/6915/console and https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/479493/

17:27:07 1) McsContentProviderTest::testGetHtmlWithNoResponse
17:27:07 Undefined index: 1
17:27:07 
17:27:07 /workspace/src/includes/http/MWHttpRequest.php:424
17:27:07 /workspace/src/includes/http/CurlHttpRequest.php:138
17:27:07 /workspace/src/extensions/MobileFrontend/includes/content-providers/McsContentProvider.php:61
17:27:07 /workspace/src/extensions/MobileFrontend/includes/content-providers/McsContentProvider.php:81
17:27:07 /workspace/src/extensions/MobileFrontend/tests/phpunit/content-providers/McsContentProviderTest.php:112
17:27:07 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
17:27:07 /workspace/src/maintenance/doMaintenance.php:94

Blocking a partial revert to fix T211886

Details

SubjectRepoBranchLines +/-
Revert "Add PHPUnit tests for methods in McsContentProvider::class"mediawiki/extensions/MobileFrontendmaster+6 -206
Revert "Add PHPUnit tests for methods in McsContentProvider::class"mediawiki/extensions/MobileFrontendwmf/1.33.0-wmf.8+5 -205
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Dec 13 2018, 5:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2018, 5:33 PM
Reedy triaged this task as High priority.Dec 13 2018, 5:36 PM
Reedy updated the task description. (Show Details)
Reedy added subscribers: pmiazga, xSavitar.
gerritbot subscribed.Dec 13 2018, 5:45 PM

Change 479495 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Revert "Add PHPUnit tests for methods in McsContentProvider::class"

https://gerrit.wikimedia.org/r/479495

gerritbot added a project: Patch-For-Review.Dec 13 2018, 5:45 PM
Jdlrobson mentioned this in T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests.Dec 13 2018, 5:46 PM
gerritbot added a comment.Dec 13 2018, 8:32 PM

Change 479495 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Revert "Add PHPUnit tests for methods in McsContentProvider::class"

https://gerrit.wikimedia.org/r/479495

xSavitar closed this task as Resolved.Dec 13 2018, 8:34 PM
xSavitar assigned this task to Jdlrobson.
xSavitar added a subscriber: Jdlrobson.

Resolving this! Thanks for reporting @Reedy and for a quick fix @Jdlrobson.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 13 2018, 9:00 PM
gerritbot added a comment.Dec 13 2018, 9:36 PM

Change 479551 had a related patch set uploaded (by Reedy; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.8] Revert "Add PHPUnit tests for methods in McsContentProvider::class"

https://gerrit.wikimedia.org/r/479551

gerritbot added a comment.Dec 13 2018, 9:51 PM

Change 479551 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.8] Revert "Add PHPUnit tests for methods in McsContentProvider::class"

https://gerrit.wikimedia.org/r/479551

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.8; 2018-12-11); removed MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 13 2018, 10:01 PM
Stashbot subscribed.Dec 13 2018, 10:29 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-13T22:29:20Z] <reedy@deploy1001> Synchronized php-1.33.0-wmf.8/extensions/MobileFrontend: T211903 (duration: 00m 48s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits