Page MenuHomePhabricator
Create Task
Maniphest T212666

PHPUnit: Cover methods in content-providers/MwApiContentProvider.php with unit tests
Closed, ResolvedPublic
Actions

Description

Code coverage for the content-providers/MwApiContentProvider.php is 0% and unit tests should be written to cover all it's code.

Acceptance Criteria

  • Cover all methods in the file class
  • Code Coverage has gone up to 100%

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+1 -1Hygiene: simplify the if statement
mediawiki/extensions/MobileFrontendmaster+219 -1tests: Add PHPUnit tests for MwApiContentProviderTest::class
Customize query in gerrit

Related Objects
Search...

Event Timeline

xSavitar created this task.Dec 28 2018, 12:06 PM
xSavitar mentioned this in T212408: Refactor the /content-providers/MwApiContentProvider.php class for ease of writing PHPUnit tests.
gerritbot added a subscriber: gerritbot.Jan 2 2019, 10:47 AM

Change 481841 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] tests: Add PHPUnit tests for MwApiContentProviderTest::class

https://gerrit.wikimedia.org/r/481841

gerritbot added a project: Patch-For-Review.Jan 2 2019, 10:47 AM
xSavitar claimed this task.Jan 2 2019, 10:59 AM
xSavitar triaged this task as Medium priority.
xSavitar moved this task from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.
xSavitar moved this task from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Jan 2 2019, 1:55 PM
xSavitar moved this task from Doing [WIP] to Reviewed/Resolved on the User-xSavitar board.
MBinder_WMF moved this task from Readers-Web-Kanbanana-Board-2018-19-Q2 to Readers-Web-Kanbanana-Board-2018-19-Q3 on the Readers-Web-Backlog board.Jan 2 2019, 5:31 PM
MBinder_WMF edited projects, added Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3); removed Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2).
MBinder_WMF moved this task from To Do to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 2 2019, 5:33 PM
Jdlrobson moved this task from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 7 2019, 7:37 PM
xSavitar awarded a token.Jan 8 2019, 10:57 AM
xSavitar moved this task from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

@Jdlrobson, last but one additional code path has now been covered, we're at 100% 🎉🎉🎉🎉🎉🎉🎉

• pmiazga moved this task from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 8 2019, 4:46 PM
Jdlrobson awarded a token.Jan 8 2019, 6:25 PM
xSavitar moved this task from Reviewed/Resolved to Doing [WIP] on the User-xSavitar board.Jan 9 2019, 9:40 PM
Jdlrobson moved this task from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 9 2019, 10:53 PM
Jdlrobson moved this task from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 11 2019, 1:24 AM
Jdlrobson edited projects, added Readers-Web-Backlog; removed Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3).Jan 16 2019, 6:09 PM
Jdlrobson moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.Jan 16 2019, 6:35 PM
xSavitar moved this task from Doing [WIP] to Reviewed/Resolved on the User-xSavitar board.Jan 21 2019, 8:33 AM
xSavitar edited projects, added Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3); removed Readers-Web-Backlog.
xSavitar moved this task from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
gerritbot added a comment.Jan 23 2019, 10:05 PM

Change 481841 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] tests: Add PHPUnit tests for MwApiContentProviderTest::class

https://gerrit.wikimedia.org/r/481841

Jdlrobson reassigned this task from xSavitar to • pmiazga.Jan 23 2019, 10:33 PM
Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

Can you sign this off Piotr?

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 23 2019, 11:00 PM
gerritbot added a comment.Jan 25 2019, 4:11 PM

Change 486492 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Hygiene: simplify the if statement

https://gerrit.wikimedia.org/r/486492

gerritbot added a comment.Jan 25 2019, 4:33 PM

Change 486492 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: simplify the if statement

https://gerrit.wikimedia.org/r/486492

• pmiazga added a comment.Jan 25 2019, 4:47 PM

Looks good.

image.png (279×1 px, 40 KB)

• pmiazga closed this task as Resolved.Jan 25 2019, 4:47 PM
• pmiazga updated the task description. (Show Details)
xSavitar added a comment.Jan 25 2019, 4:48 PM

image.png (279×1 px, 40 KB)

Thank you very much for the recent patch :) That folder coverage really looks good :)

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL