Page MenuHomePhabricator
Create Task
Maniphest T212666

PHPUnit: Cover methods in content-providers/MwApiContentProvider.php with unit tests
Closed, ResolvedPublic
Actions

Description

Code coverage for the content-providers/MwApiContentProvider.php is 0% and unit tests should be written to cover all it's code.

Acceptance Criteria

  • Cover all methods in the file class
  • Code Coverage has gone up to 100%

Related Objects
Search...

Event Timeline

gerritbot added a subscriber: gerritbot.Jan 2 2019, 10:47 AM

Change 481841 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] tests: Add PHPUnit tests for MwApiContentProviderTest::class

https://gerrit.wikimedia.org/r/481841

D3r1ck01 moved this task from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Jan 2 2019, 10:59 AM
D3r1ck01 moved this task from Backlog to Doing [WIP] on the User-D3r1ck01 board.
D3r1ck01 claimed this task.
D3r1ck01 triaged this task as Normal priority.
D3r1ck01 awarded a token.Jan 8 2019, 10:57 AM
D3r1ck01 moved this task from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

@Jdlrobson, last but one additional code path has now been covered, we're at 100% 🎉🎉🎉🎉🎉🎉🎉

gerritbot added a comment.Jan 23 2019, 10:05 PM

Change 481841 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] tests: Add PHPUnit tests for MwApiContentProviderTest::class

https://gerrit.wikimedia.org/r/481841

gerritbot added a comment.Jan 25 2019, 4:11 PM

Change 486492 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Hygiene: simplify the if statement

https://gerrit.wikimedia.org/r/486492

gerritbot added a comment.Jan 25 2019, 4:33 PM

Change 486492 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: simplify the if statement

https://gerrit.wikimedia.org/r/486492

pmiazga added a comment.Jan 25 2019, 4:47 PM

Looks good.

pmiazga closed this task as Resolved.Jan 25 2019, 4:47 PM
pmiazga updated the task description. (Show Details)
D3r1ck01 added a comment.Jan 25 2019, 4:48 PM

Thank you very much for the recent patch :) That folder coverage really looks good :)

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL