Page MenuHomePhabricator

PHPUnit: Cover methods in content-providers/MwApiContentProvider.php with unit tests
Closed, ResolvedPublic

Description

Code coverage for the content-providers/MwApiContentProvider.php is 0% and unit tests should be written to cover all it's code.

Acceptance Criteria

  • Cover all methods in the file class
  • Code Coverage has gone up to 100%

Event Timeline

Change 481841 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/extensions/MobileFrontend@master] tests: Add PHPUnit tests for MwApiContentProviderTest::class

https://gerrit.wikimedia.org/r/481841

D3r1ck01 moved this task from Backlog to Doing [WIP] on the User-D3r1ck01 board.
D3r1ck01 claimed this task.
D3r1ck01 triaged this task as Normal priority.

@Jdlrobson, last but one additional code path has now been covered, we're at 100% 🎉🎉🎉🎉🎉🎉🎉

Change 481841 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] tests: Add PHPUnit tests for MwApiContentProviderTest::class

https://gerrit.wikimedia.org/r/481841

Change 486492 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Hygiene: simplify the if statement

https://gerrit.wikimedia.org/r/486492

Change 486492 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: simplify the if statement

https://gerrit.wikimedia.org/r/486492

Looks good.

pmiazga closed this task as Resolved.Jan 25 2019, 4:47 PM
pmiazga updated the task description. (Show Details)

Thank you very much for the recent patch :) That folder coverage really looks good :)