Page MenuHomePhabricator
Create Task
Maniphest T213227

Wikibase RepoHooks::onApiCheckCanExecute dies (via EntityHandler::getEntityNamespaces's assert) for all edits on wikis where Item isn't enabled?
Closed, ResolvedPublic
Actions

Description

Try to edit a File page with an API editor, like VE, or mobile, and the edit fails with a PHP fatal.

This is because RepoHooks::onApiCheckCanExecute calls EntityHandler::getEntityNamespaces to work out what namespaces to care about, and the latter doesn't check for enabled-ness.

Details

SubjectRepoBranchLines +/-
RepoHooks::onApiCheckCanExecute: Only fail if the edit is for our entity's slotmediawiki/extensions/Wikibasewmf/1.33.0-wmf.12+10 -1
RepoHooks::onApiCheckCanExecute: Only fail if the edit is for our entity's slotmediawiki/extensions/Wikibasemaster+10 -1
RepoHooks::onApiCheckCanExecute only check enabled entity typesmediawiki/extensions/Wikibasewmf/1.33.0-wmf.12+8 -2
RepoHooks::onApiCheckCanExecute only check enabled entity typesmediawiki/extensions/Wikibasemaster+8 -2
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF triaged this task as Unbreak Now! priority.Jan 8 2019, 11:19 PM
Jdforrester-WMF created this task.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes, Aklapper. · View Herald TranscriptJan 8 2019, 11:19 PM
Jdforrester-WMF added a comment.Jan 8 2019, 11:25 PM

Logstash AWgvwoVwzpjgITg6nyED.

gerritbot subscribed.Jan 8 2019, 11:27 PM

Change 483030 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] RepoHooks::onApiCheckCanExecute only check enabled entity types

https://gerrit.wikimedia.org/r/483030

gerritbot added a project: Patch-For-Review.Jan 8 2019, 11:27 PM
Addshore added a comment.Jan 8 2019, 11:28 PM

Logstash: https://logstash.wikimedia.org/goto/63f5a27a4049ad1a52decf716ea45f31

gerritbot added a comment.Jan 9 2019, 12:28 AM

Change 483030 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] RepoHooks::onApiCheckCanExecute only check enabled entity types

https://gerrit.wikimedia.org/r/483030

gerritbot added a comment.Jan 9 2019, 12:34 AM

Change 483041 had a related patch set uploaded (by Jforrester; owner: Addshore):
[mediawiki/extensions/Wikibase@wmf/1.33.0-wmf.12] RepoHooks::onApiCheckCanExecute only check enabled entity types

https://gerrit.wikimedia.org/r/483041

Jdforrester-WMF moved this task from To Do to Verify on Production on the Structured Data Engineering board.Jan 9 2019, 12:39 AM
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.12; 2019-01-08); removed Patch-For-Review.

Deploying now.

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.13; 2019-01-15); removed MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Jan 9 2019, 1:00 AM
gerritbot added a comment.Jan 9 2019, 1:02 AM

Change 483041 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.33.0-wmf.12] RepoHooks::onApiCheckCanExecute only check enabled entity types

https://gerrit.wikimedia.org/r/483041

Stashbot subscribed.Jan 9 2019, 1:15 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-09T01:15:24Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.12/extensions/Wikibase/repo/RepoHooks.php: T213227 Don't have onApiCheckCanExecute die for inactive entity types (duration: 00m 53s)

Addshore claimed this task.Jan 9 2019, 1:16 AM
Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).
Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 9 2019, 1:16 AM
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.12; 2019-01-08); removed MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 9 2019, 1:17 AM

OK, this is no longer fataling, but it's erroring with wikibase-no-direct-editing instead. Needs a slot check, I guess. Leaving UBN as it's the last blocker to release.

gerritbot added a comment.Jan 9 2019, 1:31 AM

Change 483049 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Wikibase@master] RepoHooks::onApiCheckCanExecute: Only fail if the edit is for our entity's slot

https://gerrit.wikimedia.org/r/483049

gerritbot added a project: Patch-For-Review.Jan 9 2019, 1:31 AM
Addshore mentioned this in T200570: Make ApiEditPage and ApiStashEdit API modules aware of MCR.Jan 9 2019, 1:06 PM
gerritbot added a comment.Jan 9 2019, 1:28 PM

Change 483049 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] RepoHooks::onApiCheckCanExecute: Only fail if the edit is for our entity's slot

https://gerrit.wikimedia.org/r/483049

Addshore moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 9 2019, 1:57 PM
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.13; 2019-01-15); removed MW-1.33-notes (1.33.0-wmf.12; 2019-01-08).Jan 9 2019, 2:00 PM
gerritbot added a comment.Jan 9 2019, 3:29 PM

Change 483146 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Wikibase@wmf/1.33.0-wmf.12] RepoHooks::onApiCheckCanExecute: Only fail if the edit is for our entity's slot

https://gerrit.wikimedia.org/r/483146

gerritbot added a comment.Jan 9 2019, 4:03 PM

Change 483146 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.33.0-wmf.12] RepoHooks::onApiCheckCanExecute: Only fail if the edit is for our entity's slot

https://gerrit.wikimedia.org/r/483146

Stashbot added a comment.Jan 9 2019, 4:11 PM

Mentioned in SAL (#wikimedia-operations) [2019-01-09T16:11:26Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.12/extensions/Wikibase/repo/RepoHooks.php: T213227 RepoHooks::onApiCheckCanExecute: Only fail if the edit is for our entity's slot (duration: 00m 54s)

Jdforrester-WMF closed this task as Resolved.Jan 9 2019, 4:14 PM
Jdforrester-WMF removed a project: Patch-For-Review.

Fixed.

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.12; 2019-01-08); removed MW-1.33-notes (1.33.0-wmf.13; 2019-01-15).Jan 9 2019, 5:00 PM
Liuxinyu970226 unsubscribed.Jan 16 2019, 1:35 AM
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 28 2019, 10:50 AM
greg added a project: Multimedia.Mar 7 2019, 10:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits