Page MenuHomePhabricator
Create Task
Maniphest T214211

Migrate all (static) uses of the deprecated ResourceLoaderTestModules hook to the QUnitTestModule extension.json attribute
Closed, ResolvedPublic
Actions

Description

Test plan:

  • The hook code should be removed from both the extension.json call, and from the Hooks PHP file itself.
  • The number of QUnit tests run before and after should be the same
  • The QUnit tests should still pass. :-)

Wikimedia-deployed

  • MinervaNeue (the skin)
  1. Non-static (has a dependency), so not yet
  2. Cite
  3. Citoid
  4. Graph
  5. GuidedTour
  1. Non-static (dynamic test file / dependency finding, ¡¿why?!), so not yet
  2. CentralNotice
  3. Echo
  4. Flow
  5. UploadWizard
  1. Not yet on extension.json, so not yet
  2. Translate (on extension.json but waiting for compatibility to lapse)
  3. Wikibase

Extensions not deployed at Wikimedia

  • examples
  • BlueSpiceExtendedSearch
  • FormWizard
  • SemanticMediaWiki
  • SemanticResultFormats
  • Wikispeech

Details

SubjectRepoBranchLines +/-
Replace use of deprecated ResourceLoaderTestModules hookmediawiki/extensions/UniversalLanguageSelectormaster+11 -17
Replace use of deprecated ResourceLoaderTestModules hookmediawiki/extensions/MultimediaViewermaster+65 -79
Replace use of deprecated ResourceLoaderTestModules hookmediawiki/extensions/CentralAuthmaster+6 -13
Replace use of deprecated ResourceLoaderTestModules hookmediawiki/extensions/WikiEditormaster+6 -21
Replace use of deprecated ResourceLoaderTestModules hookmediawiki/extensions/MobileFrontendmaster+13 -39
Replace use of deprecated ResourceLoaderTestModules hookmediawiki/extensions/EventLoggingmaster+13 -23
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF changed the task status from Open to Stalled.Jan 18 2019, 10:28 PM
Jdforrester-WMF created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2019, 10:28 PM
Jdforrester-WMF added a subtask: T126091: Make it possible to register ResourceLoaderTestModules in extension.json.Jan 18 2019, 10:28 PM
Jdforrester-WMF renamed this task from Migrate all (static) uses of the ResourceLoaderTestModules hook to the new ResourceLoaderQUnitTestModules extension.json attribute to Migrate all (static) uses of the deprecated ResourceLoaderTestModules hook to the QUnitTestModule extension.json attribute.Feb 6 2019, 12:16 AM
Jdforrester-WMF changed the task status from Stalled to Open.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF closed subtask T126091: Make it possible to register ResourceLoaderTestModules in extension.json as Resolved.Feb 6 2019, 12:19 AM
Jdforrester-WMF updated the task description. (Show Details)Feb 13 2019, 10:19 PM
Jdforrester-WMF updated the task description. (Show Details)Feb 13 2019, 10:46 PM
gerritbot subscribed.Feb 13 2019, 10:50 PM

Change 490488 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/UniversalLanguageSelector@master] Replace use of deprecated ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/490488

gerritbot added a project: Patch-For-Review.Feb 13 2019, 10:50 PM
gerritbot added a comment.Feb 13 2019, 10:53 PM

Change 490489 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikiEditor@master] Replace use of deprecated ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/490489

gerritbot added a comment.Feb 13 2019, 10:56 PM

Change 490490 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/EventLogging@master] Replace use of deprecated ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/490490

gerritbot added a comment.Feb 13 2019, 11:02 PM

Change 490491 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/MobileFrontend@master] Replace use of deprecated ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/490491

gerritbot added a comment.Feb 13 2019, 11:05 PM

Change 490494 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/MultimediaViewer@master] Replace use of deprecated ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/490494

gerritbot added a comment.Feb 13 2019, 11:07 PM

Change 490495 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/CentralAuth@master] Replace use of deprecated ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/490495

Jdforrester-WMF updated the task description. (Show Details)Feb 13 2019, 11:08 PM
gerritbot added a comment.Feb 13 2019, 11:08 PM

Change 490490 merged by Nuria:
[mediawiki/extensions/EventLogging@master] Replace use of deprecated ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/490490

gerritbot added a comment.Feb 13 2019, 11:50 PM

Change 490491 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Replace use of deprecated ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/490491

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.18; 2019-02-19).Feb 14 2019, 12:01 AM
gerritbot added a comment.Feb 15 2019, 9:09 PM

Change 490489 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Replace use of deprecated ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/490489

gerritbot added a comment.Mar 5 2019, 12:31 PM

Change 490495 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Replace use of deprecated ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/490495

gerritbot added a comment.Mar 5 2019, 1:06 PM

Change 490494 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Replace use of deprecated ResourceLoaderTestModules hook

https://gerrit.wikimedia.org/r/490494

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.21; 2019-03-12); removed MW-1.33-notes (1.33.0-wmf.18; 2019-02-19).Mar 5 2019, 5:04 PM
Jdforrester-WMF updated the task description. (Show Details)Dec 16 2019, 8:14 AM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptDec 16 2019, 8:14 AM
Krinkle awarded a token.May 28 2020, 3:39 AM
gerritbot added a comment.Apr 21 2021, 1:21 PM

Change 490488 abandoned by Nikerabbit:

[mediawiki/extensions/UniversalLanguageSelector@master] Replace use of deprecated ResourceLoaderTestModules hook

Reason:

This has been done sometime in the meanwhile. :(

https://gerrit.wikimedia.org/r/490488

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2021, 2:10 PM
Umherirrender closed this task as Resolved.Feb 13 2023, 10:43 PM
Umherirrender subscribed.

Hook is now removed with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/861504

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits