Page MenuHomePhabricator

Prevent redirecting an entity to itself - In the Wikibase DataModel
Closed, ResolvedPublic

Description

EntityRedirect currently says "Represents a redirect from one EntityId to another." but actually allows using the same ID.

The constructor should disallow this.

  • Updated data model
  • Release data model (Released 9.1.0)
  • Use data model everywhere...

Event Timeline

Addshore triaged this task as Medium priority.Jan 29 2019, 2:28 PM
Addshore created this task.
Addshore updated the task description. (Show Details)

Change 487846 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Fix tests that redirect an entity to itself

https://gerrit.wikimedia.org/r/487846

Change 487850 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/vendor@master] Update wikibase datamodel to 9.1.0

https://gerrit.wikimedia.org/r/487850

Change 487846 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix tests that redirect an entity to itself

https://gerrit.wikimedia.org/r/487846

Change 487850 merged by jenkins-bot:
[mediawiki/vendor@master] Update wikibase datamodel to 9.1.0

https://gerrit.wikimedia.org/r/487850

Change 488015 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] Adapt tests to cope with EntityRedirect exception

https://gerrit.wikimedia.org/r/488015

Change 488015 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Adapt tests to cope with EntityRedirect exception

https://gerrit.wikimedia.org/r/488015