Regression: UBN! Languages feature broken on beta cluster
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 8 2019, 7:15 PM

Description

Regression caught by browser tests.

QA steps

Click the language button on https://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_language_test_page
Expected: language overlay opens
Actual: Language overlay fails to open

Developer notes

Uncaught TypeError: Cannot read property 'call' of undefined
    at <anonymous>:1:228

can be seen in the console.

QA Results

Status	Details
✅ Passed	T215648#4946241

Details

	Subject	Repo	Branch	Lines +/-
	Fix: PageGateway TypeError in LanguageOverlay	mediawiki/extensions/MobileFrontend	master	+3 -2
	Hygiene: move PageGateway import to top	mediawiki/skins/MinervaNeue	master	+2 -2

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Feb 8 2019, 7:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2019, 7:15 PM

Jdlrobson triaged this task as Unbreak Now! priority.Feb 8 2019, 7:15 PM

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptFeb 8 2019, 7:15 PM

Jdlrobson renamed this task from UBN! Languages feature broken on beta cluster to Regression: UBN! Languages feature broken on beta cluster.Feb 8 2019, 7:16 PM

Jdlrobson added a project: Regression.

Jdlrobson updated the task description. (Show Details)

Change 489300 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Fix: PageGateway TypeError in LanguageOverlay

https://gerrit.wikimedia.org/r/489300

gerritbot added a project: Patch-For-Review.Feb 8 2019, 7:27 PM

Change 489301 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Hygiene: move PageGateway import to top

https://gerrit.wikimedia.org/r/489301

Change 489300 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix: PageGateway TypeError in LanguageOverlay

https://gerrit.wikimedia.org/r/489300

Change 489301 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Hygiene: move PageGateway import to top

https://gerrit.wikimedia.org/r/489301

Jdlrobson moved this task from To Do to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Feb 8 2019, 8:18 PM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.17; 2019-02-12).Feb 8 2019, 9:00 PM

Dropping priority as the patch is now merged, so that it doesn't show up in alerts.

ovasileva assigned this task to Edtadros.Feb 11 2019, 10:24 AM

ovasileva moved this task from Ready for Signoff to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Test Artifact(s):

When language overlay is tapped the overlay opens:

Screen Shot 2019-02-11 at 8.04.33 PM.png (817×382 px, 24 KB)

When it is dismissed or the language is selected, the overlay disappears:

Screen Shot 2019-02-11 at 8.04.45 PM.png (818×383 px, 53 KB)

Screen Shot 2019-02-11 at 8.04.58 PM.png (817×380 px, 56 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Feb 12 2019, 4:08 AM

Edtadros updated the task description. (Show Details)

Edtadros moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

Edtadros subscribed.

looks good, resolving

Liuxinyu970226 unsubscribed.Feb 15 2019, 1:47 PM

Edtadros added a project: Product-QA (RW-Test-Cases).Mar 7 2019, 5:51 PM

ovasileva moved this task from Backlog to Advanced Mobile Contributions on the Product-QA (RW-Test-Cases) board.Mar 2 2020, 6:40 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptMar 2 2020, 6:40 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2020, 7:13 PM

	F28198377: Screen Shot 2019-02-11 at 8.04.45 PM.png
	Feb 12 2019, 4:07 AM

	F28198380: Screen Shot 2019-02-11 at 8.04.58 PM.png
	Feb 12 2019, 4:07 AM

	F28198375: Screen Shot 2019-02-11 at 8.04.33 PM.png
	Feb 12 2019, 4:07 AM

Regression: UBN! Languages feature broken on beta clusterClosed, ResolvedPublicActions