Page MenuHomePhabricator

Show user-specific termbox result for users with non-default configuration
Closed, ResolvedPublic


Implement through "additional" termbox request during EntityViewPlaceholderExpander
Request is needed if user's configuration (currently "preferred languages" only) differs from the configuration that is used to build the generic termbox version that is stored in ParserCache.

Idea for getting to the language fallback chains to compare:

$wikibaseRepo = WikibaseRepo::getDefaultInstance();

$parserCacheLanguages = $wikibaseRepo->getLanguageFallbackChainFactory()
	->newFromLanguage( $language );

$userPreferredLanguages = $wikibaseRepo->getLanguageFallbackChainFactory()
	->newFromContext( RequestContext::getMain() );

Event Timeline

Pablo-WMDE triaged this task as Normal priority.Feb 11 2019, 1:42 PM
Pablo-WMDE created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2019, 1:42 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-10 board.

Change 494711 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Re-render the Termbox in case of non-default requests

Change 494711 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Re-render the Termbox in case of non-default requests

Pablo-WMDE closed this task as Resolved.Apr 8 2019, 10:40 AM