Page MenuHomePhabricator

Ensure edit pen visibility is conditional
Closed, ResolvedPublic

Description

So far, edit pen visibility is controlled through the proprietary <wb:sectionedit> tag (see Sectionedit component). Ensure that the solution implemented for T215788 keeps this a viable option.


(dev system with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/490369 checked out)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2019, 9:44 PM
Pablo-WMDE updated the task description. (Show Details)Feb 13 2019, 9:47 PM
Pablo-WMDE added a subscriber: Jakob_WMDE.

Ohh, well spotted. It appears that the html blob we add to ParserOutput through setExtensionData does not pass through RepoHooks::onParserOutputPostCacheTransform.

Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-10 board.

Change 493419 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Ensure edit pen visibility is conditional

https://gerrit.wikimedia.org/r/493419

Change 494198 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Ensure edit pen visibility is conditional

https://gerrit.wikimedia.org/r/494198

Change 493419 abandoned by Jakob:
Ensure edit pen visibility is conditional

https://gerrit.wikimedia.org/r/493419

Change 494198 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Ensure edit pen visibility is conditional

https://gerrit.wikimedia.org/r/494198

@Pablo-WMDE, @Jakob_WMDE: All patches merged/abandoned and no active project tags assigned. If there is nothing left to do here, please feel free to resolve this task via the Add Action...Change Status dropdown. If there is work left, please add an active project tag. Thanks!

Jakob_WMDE closed this task as Resolved.Apr 15 2019, 8:59 AM