Page MenuHomePhabricator

Presence of <section /> tag confuses Linter analyis when using 'continued' tables....
Open, Needs TriagePublic


The following page,_vol_1.djvu/337&action=edit&lintid=1080094 was being detected as having a "fostered content" concern.

The only fostered content that could be located was a <section /> tag, which is used by LST to mark the start of a 'section'. Removing the <section /> tag from the markup caused the fostered content concern to vanish. The presence of the section tag is not however an error, as Wikisource uses <section /> tags extensively. Having Linter erroneously report a 'fostered' content concern. Linter mis-reporting these where no fostered content actually exists is tiresome.

What should have happened is that the <Section /> tag should once noted for the purposes of building a transcluded section have been stripped from the output, and from the markup supplied to the Linter analyser.

Of course if Mediawiki had a more sensible way of splitting table sections (the current markup and handling having been designed for single page use....) then concerns like this would be less important...

(Aside: The use of section tags for LST possibly conflicts with HTML5)

Event Timeline

-jkb- removed a subscriber: -jkb-.

Another example:-

here the 'fostered content' arose due to very very specfic whitespace handling around the <section /> tag ( which I've still not seen any documentation on, despite having raised that issue on Phabricator in the past.)

Dinoguy1000 renamed this task from Presence of<section /> tag confuses Linter analyis when using 'continued' tables.... to Presence of <section /> tag confuses Linter analyis when using 'continued' tables.....Feb 17 2019, 5:38 PM
Dinoguy1000 updated the task description. (Show Details)

This problem appears to be still happening, for example at:

Expanding one of the tables in that page on Special:ExpandTemplates shows that no additional HTML code appears to be displayed above the table. With an actual Fostered content error, there should be something rendered above the table.

According to the Page information Linter error counts, this is the article with the most Linter errors on all of English Wikipedia as of today. (Although it is not actually the article with the most errors, because the Page information counts are often inaccurate; see T246403 for details on that bug.)

It would be great if Linter could ignore these section tags.

FYI, I was able to fix the Doctor Who article by removing line breaks before the the section tags:

I don't know if the same fix could have been applied to the wikisource pages.

Until someone analyses what is happening in the lint component for what is otherwise non-problematic code elsewhere, then who knows.

With reference to Jonesey95's Dr Who article, newlines before section tags are impossible to avoid in the WS page namespace, because there are some hardcoded newlines inserted by the extension before the body text (see T275388 for a place this causes an actual issue in the wikicode, rather than the linter).

Doesn't mean it's not something the linter could no choke on, but it's also sadly not something Wikisource users can avoid by changing the markup.