Remove shadow from the Toolbar on Reading themes (dark, black, sepia)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmadeo
	Feb 19 2019, 8:39 PM

Description

Why are we doing this?

Due to the lower contrast on secondary reading themes with shadows, we have removed shadows from the Explore feed and other parts of the app for these themes. We would like to be consistent and not show a shadow on Dark, Black and Sepia in the editing mode.

User story

As a user of secondary reading themes, I would like my experience to be consistent.

Proposed solution

Remove the shadow from the editing toolbar on Dark, Black and Sepia

Sepia

Current	Updated

Dark + Black

Current	Updated Dark	Updated Black

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		• JMinor	T209168 Wikitext editing tools
Resolved	BUG REPORT	JoeWalsh	T215639 [BUG] Add a shadow behind the toolbar of the editing view
Resolved		• NHarateh_WMF	T216551 Remove shadow from the Toolbar on Reading themes (dark, black, sepia)

Event Timeline

cmadeo created this task.Feb 19 2019, 8:39 PM

cmadeo added a project: iOS-app-v6.2.1-Beluga-On-Stilts.Feb 26 2019, 8:04 PM

cmadeo moved this task from Tasks from Product Backlog to Needs Design on the iOS-app-v6.2.1-Beluga-On-Stilts board.

• JMinor triaged this task as Low priority.Feb 27 2019, 11:39 PM

• JMinor moved this task from Needs Triage to Product Backlog on the Wikipedia-iOS-App-Backlog board.

cmadeo moved this task from Needs Design to Design Doing on the iOS-app-v6.2.1-Beluga-On-Stilts board.Mar 5 2019, 9:52 PM

cmadeo edited projects, added iOS-app-v6.3-Lobster-On-A-Motorcycle; removed iOS-app-v6.2.1-Beluga-On-Stilts.Mar 14 2019, 8:18 PM

• JMinor moved this task from Tasks from Product Backlog to Needs Design on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.Mar 25 2019, 9:06 PM

cmadeo moved this task from Needs Design to Design Doing on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.May 1 2019, 8:14 PM

cmadeo renamed this task from Audit of shadows for non-default reading themes throughout the app to Remove shadow from the Toolbar on Reading themes (dark, black, sepia) .May 2 2019, 7:05 PM

cmadeo updated the task description. (Show Details)

cmadeo moved this task from Design Doing to Needs Acceptance Criteria on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.

LGoto moved this task from Needs Acceptance Criteria to Ready for Development on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.May 2 2019, 8:05 PM

• NHarateh_WMF claimed this task.May 14 2019, 2:19 PM

• NHarateh_WMF moved this task from Ready for Development to Needs Code Review on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.

@cmadeo are the color changes on the toolbar and navbar intentional and a part of this ticket or should the only change be the shadow removal?

@JoeWalsh Good eye, sorry the header (nav bar) should not be included (this was my mistake), but the editing toolbar should be updated so that there is enough depth without the shadow. Thank you!

• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.May 14 2019, 4:21 PM

@cmadeo would you want to remove the shadows from the input views too (& update the bg color)?

Simulator Screen Shot - iPhone Xʀ - 2019-05-14 at 12.25.54.png (1×828 px, 256 KB)

Simulator Screen Shot - iPhone Xʀ - 2019-05-14 at 12.26.09.png (1×828 px, 255 KB)

For color updates, would you want to go with the ones in the screenshots or something else?

I picked new colors with Color Picker so they're probably off 🙈

current sepia f0e6d6 -> new sepia eee6d8?
current dark 27292D -> new dark 27292d?
current black 222222 -> new black 27292d?

@NHarateh_WMF Ah! Yes, if you could remove them from the input views too that would be great!
Sorry! I should have linked to Zeplin: https://app.zeplin.io/project/57a120ce9787dcf26230651f/dashboard?seid=5c367a1180fc3e29bdfba1d0

Theme	New color
Black	`#27292d`
Dark	`#27292d`
Sepia	`#F0E6D6`

• NHarateh_WMF moved this task from Doing to Needs Code Review on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.May 14 2019, 6:31 PM

• NHarateh_WMF moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.May 16 2019, 12:11 PM

• NHarateh_WMF moved this task from Waiting for Build to Needs Design Review on the iOS-app-v6.3-Lobster-On-A-Motorcycle board.

Looking good! Thanks @NHarateh_WMF!

Looks good to me on 6.3.0 (1627)

• JMinor closed this task as Resolved.Jul 10 2019, 3:48 PM

	F29051963: Simulator Screen Shot - iPhone Xʀ - 2019-05-14 at 12.26.09.png
	May 14 2019, 4:27 PM

	F29051961: Simulator Screen Shot - iPhone Xʀ - 2019-05-14 at 12.25.54.png
	May 14 2019, 4:27 PM

	F28905275: 03 Template collapsed Black.png
	May 2 2019, 7:05 PM

	F28905271: 03 Template collapsed Dark.png
	May 2 2019, 7:05 PM

	F28905264: 03 Template collapsed SEPIA.png
	May 2 2019, 7:05 PM

Remove shadow from the Toolbar on Reading themes (dark, black, sepia) Closed, ResolvedPublicActions