Page MenuHomePhabricator
Create Task
Maniphest T216662

WikibaseLexeme ApiUserBlockedTest is broken
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

ApiUserBlockedTest expects error messages like 'blockedtext', 'no-permission' to be produced on block. However, in ApiBase, addBlockInfoToStatus() replaces blockedtext with apierror-blocked. Thus the test is broken. This seems to be added in commit ace0338421b6f100d4fde475206d165bd0b3afeb.

Details

SubjectRepoBranchLines +/-
Fix ApiUserBlockedTest testmediawiki/extensions/WikibaseLexememaster+6 -6
Customize query in gerrit

Related Objects

Event Timeline

Smalyshev created this task.Feb 20 2019, 10:37 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptFeb 20 2019, 10:37 PM
Smalyshev triaged this task as High priority.Feb 20 2019, 10:37 PM
gerritbot subscribed.Feb 20 2019, 10:39 PM

Change 491865 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikibaseLexeme@master] Fix ApiUserBlockedTest test

https://gerrit.wikimedia.org/r/491865

gerritbot added a project: Patch-For-Review.Feb 20 2019, 10:39 PM
Diffusion mentioned this in rEWLEe7d75e7c9e96: Fix ApiUserBlockedTest test.Feb 20 2019, 10:43 PM
Lydia_Pintscher added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Feb 21 2019, 9:08 AM
Lydia_Pintscher moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 21 2019, 9:46 AM
Nikerabbit mentioned this in T216689: Merge blocker: quibble-vendor-mysql-hhvm-docker in gate fails for most merges (exit status -11).Feb 21 2019, 10:10 AM
Jdforrester-WMF subscribed.Feb 21 2019, 10:18 AM

I thought Lexeme was now in gate? How did the core change land?

gerritbot added a comment.Feb 21 2019, 10:24 AM

Change 491865 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix ApiUserBlockedTest test

https://gerrit.wikimedia.org/r/491865

Jdforrester-WMF signed these changes with MFA.Feb 21 2019, 10:49 AM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF assigned this task to Smalyshev.
Jdforrester-WMF edited projects, added Wikimedia-production-error (ARCHIVED -- Shared Build Failure); removed Patch-For-Review.
Jdforrester-WMF moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

This is now fixed, I believe.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.19; 2019-02-26).Feb 21 2019, 11:00 AM
Smalyshev added a comment.Feb 21 2019, 6:28 PM

I thought Lexeme was now in gate? How did the core change land?

I have no idea... Something seems to be wrong there. There was also a case recently where Lexeme had wrong class name and it wasn't detected. I think some CI config steps are missing for this extensions still, but not sure which.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits